Bug #8980
closedJobs comparison is broken
Added by Ilja Zakharov over 6 years ago. Updated over 6 years ago.
100%
Description
Currently comparison shows incorrect comparison results. There are the following issues:
1) In the left and in the right parts Klever shows exactly the same verification reports from the first job instead of different ones.
2) Many results in comparison are shown as broken.
3) Many reports are missed and not shown. It does not show any differences and transitions at all for example.
Files
| Job-16fbb55d74.zip (982 KB) Job-16fbb55d74.zip | Evgeny Novikov, 06/26/2018 04:12 PM | ||
| Job-2cbab5bcb6.zip (852 KB) Job-2cbab5bcb6.zip | Evgeny Novikov, 06/26/2018 04:12 PM | ||
| Screenshot_20180627_114552.png (102 KB) Screenshot_20180627_114552.png | Evgeny Novikov, 06/27/2018 11:44 AM | ||
| Job-16fbb55d74.zip (983 KB) Job-16fbb55d74.zip | Evgeny Novikov, 06/27/2018 11:56 AM | ||
| Job-aec0c4ea3f.zip (619 KB) Job-aec0c4ea3f.zip | Evgeny Novikov, 06/27/2018 11:56 AM | ||
| Screenshot_20180627_115846.png (109 KB) Screenshot_20180627_115846.png | Evgeny Novikov, 06/27/2018 11:56 AM | ||
| 1.png (43.1 KB) 1.png | a<>b | Vladimir Gratinskiy, 06/27/2018 06:35 PM | |
| 2.png (48.8 KB) 2.png | a<>b +components | Vladimir Gratinskiy, 06/27/2018 06:35 PM | |
| 3.png (67.4 KB) 3.png | a<>b +components +attrs | Vladimir Gratinskiy, 06/27/2018 06:35 PM | |
| 4.png (46 KB) 4.png | c<>b | Vladimir Gratinskiy, 06/27/2018 06:35 PM | |
| 5.png (49.9 KB) 5.png | c<>b +components | Vladimir Gratinskiy, 06/27/2018 06:35 PM | |
| 6.png (67 KB) 6.png | c<>b +components +attrs | Vladimir Gratinskiy, 06/27/2018 06:35 PM |
Updated by Evgeny Novikov over 6 years ago
- Priority changed from Urgent to Immediate
This is really what we need to fix ASAP! Vladimir, do you need examples with job archives?
Updated by Vladimir Gratinskiy over 6 years ago
- Status changed from New to Resolved
- % Done changed from 0 to 100
The first and third problem is fixed in fix_8980. The second problem for me is because there can't be several safes for one pair (rule, verification object) (if it's set as attributes to compare). But there are several Sub-jobs with the same pairs. maybe you forgot to mark "Name" attribute for comparison.
Updated by Evgeny Novikov over 6 years ago
- File Job-16fbb55d74.zip Job-16fbb55d74.zip added
- File Job-2cbab5bcb6.zip Job-2cbab5bcb6.zip added
- Status changed from Resolved to Open
I tried to fix the second issue. Can you, please, examine if there are some errors in attached job archives or Bridge compares them incorrectly? At the moment comparison looks very strange. A minor bug is: "Not Found: /reports/ajax/get_compare_jobs_data/5/".
Updated by Vladimir Gratinskiy over 6 years ago
Evgeny Novikov wrote:
I tried to fix the second issue. Can you, please, examine if there are some errors in attached job archives or Bridge compares them incorrectly? At the moment comparison looks very strange. A minor bug is: "Not Found: /reports/ajax/get_compare_jobs_data/5/".
The comparison table looks good. I've fixed some problems with hiding attributes and components in detail comparison. Now it should work perfect.
Updated by Evgeny Novikov over 6 years ago
Vladimir Gratinskiy wrote:
Evgeny Novikov wrote:
I tried to fix the second issue. Can you, please, examine if there are some errors in attached job archives or Bridge compares them incorrectly? At the moment comparison looks very strange. A minor bug is: "Not Found: /reports/ajax/get_compare_jobs_data/5/".
The comparison table looks good. I've fixed some problems with hiding attributes and components in detail comparison. Now it should work perfect.
I still do not see some components in details (see the attached screenshot). These details are for matched reports.
Besides, there is value "0" specified for field "Sub-job identifier". It seems that it has no effect, but why it is not "Any" as for other fields?
Updated by Evgeny Novikov over 6 years ago
- File Job-16fbb55d74.zip Job-16fbb55d74.zip added
- File Job-aec0c4ea3f.zip Job-aec0c4ea3f.zip added
- File Screenshot_20180627_115846.png Screenshot_20180627_115846.png added
I attached another couple of job archives and the screenshot demonstrating the issue with missed components in details. This example differs from the previous one.
Updated by Evgeny Novikov over 6 years ago
I fixed the second issue in the same branch. This issue stems from getting rid of job classes. Indeed there were many changes that improve identification of sub-jobs in general. So, I am going to test these changes while you are fixing jobs comparison.
Updated by Evgeny Novikov over 6 years ago
- Related to Feature #8437: Get rid of job classes added
Updated by Vladimir Gratinskiy over 6 years ago
- File 1.png 1.png added
- File 2.png 2.png added
- File 3.png 3.png added
- File 4.png 4.png added
- File 5.png 5.png added
- File 6.png 6.png added
I don't know what's wrong with your Bridge, but mine works perfect. Try to remove comparison caches:
CompareJobsInfo.objects.all().delete()
I've fixed issue with "Any". The problem was Any used value "0". Now it uses value "__REGEXP_ANY__". So if we have attributes with this new value we would see the issue again.
Updated by Vladimir Gratinskiy over 6 years ago
I've found the bug that exists since 12.10.2017. Fixed.
Updated by Evgeny Novikov over 6 years ago
- Status changed from Open to Resolved
Now comparison looks like a charm! Perhaps some issues were related with a wrong comparison cache. Unfortunately CI couldn't perform tests because of a strange bug that isn't likely related with this one.
Updated by Evgeny Novikov over 6 years ago
- Related to Feature #9034: Allow to clear comparison cache added
Updated by Evgeny Novikov over 6 years ago
- Blocked by Feature #9035: Change the way to identify sub-jobs added
Updated by Evgeny Novikov over 6 years ago
#9035 can be either a consequence of improvements in Core made for this issue (perhaps there was a sleeping bug that awakes after recent changes) or just a part of this issue.
Updated by Evgeny Novikov over 6 years ago
- Blocked by deleted (Feature #9035: Change the way to identify sub-jobs)
Updated by Evgeny Novikov over 6 years ago
- Related to Feature #9035: Change the way to identify sub-jobs added
Updated by Evgeny Novikov over 6 years ago
Updated by Evgeny Novikov over 6 years ago
- Status changed from Resolved to Closed
Tests passed, so, I merged the branch to master in 864de751.