Feature #8437: Get rid of job classes - Klever - Open-Source Projects

Actions

Copy link

Feature #8437

closed

Feature #8434: Get rid of job classes

Get rid of job classes

Added by Evgeny Novikov about 7 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Urgent

Assignee:

Vladimir Gratinskiy

Category:

Bridge

Target version:

1.0

Start date:

09/18/2017

Due date:

12/14/2017

% Done:

100%

Estimated time:

Published in build:

Description

A long ago I assumed that we will have a lot of job classes for various types of target programs, and for each such class Bridge should provide specific means for setting corresponding verification jobs and for visualization of their verification results. The former won't be most likely implemented ever. For the latter we suppose to use specific visualization for specific data reports, i.e. information how to treat data reports should be incorporated within them rather than to come from knowledge of job classes or component names.

Files

Screenshot.png (123 KB) Screenshot.png

Evgeny Novikov, 06/01/2018 09:50 AM

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Vladimir Gratinskiy almost 7 years ago

% Done changed from 0 to 100
Due date set to 12/14/2017
Status changed from New to Resolved

Implemented in branch "feature_8437".

Actions

Copy link

Updated by Evgeny Novikov almost 7 years ago

But how did you overcome former bindings of job classes with, say, comparison attributes and specific data report visualization? As far as I understand, you need some additional knowledge from Core to make things working as it was before.

Actions

Copy link

Updated by Vladimir Gratinskiy almost 7 years ago

Evgeny Novikov wrote:

But how did you overcome former bindings of job classes with, say, comparison attributes and specific data report visualization? As far as I understand, you need some additional knowledge from Core to make things working as it was before.

Comparison attributes are the same now for both classes and reports can be compared even if some attributes are not found. Data report visualization depends on data format. See comment in ReportData.html leading to function where format is checked.

Actions

Copy link

Updated by Vladimir Gratinskiy almost 7 years ago

Blocks Feature #8648: Allow to download/upload job subtrees added

Actions

Copy link

Updated by Evgeny Novikov over 6 years ago

Target version changed from 2.0 to 1.0

This issue was implemented together with issues for Klever 1.0.

Actions

Copy link

Updated by Evgeny Novikov over 6 years ago

File Screenshot.png Screenshot.png added
Status changed from Resolved to Open

Ilja noticed a bug (see the attached screenshot) that is most likely related with this feature implementation. But perhaps the issue is in Core which doesn't report some required data in advance.

Actions

Copy link

Updated by Vladimir Gratinskiy over 6 years ago

Evgeny Novikov wrote:

Ilja noticed a bug (see the attached screenshot) that is most likely related with this feature implementation. But perhaps the issue is in Core which doesn't report some required data in advance.

The problem is with data. For non-validation jobs "before fix" key is pointless as "after fix" doesn't exist. So the format should be like this:

{<key>: {'ideal verdict': <val>, 'verdict': <val>, 'comment': <val>}}

Comment here is not required. You can change this behavior in reports.utils.ReportData.__get_type().

Actions

Copy link

Updated by Evgeny Novikov over 6 years ago

Status changed from Open to Resolved

Vladimir Gratinskiy wrote:

Evgeny Novikov wrote:

Ilja noticed a bug (see the attached screenshot) that is most likely related with this feature implementation. But perhaps the issue is in Core which doesn't report some required data in advance.

The problem is with data. For non-validation jobs "before fix" key is pointless as "after fix" doesn't exist. So the format should be like this:

{<key>: {'ideal verdict': <val>, 'verdict': <val>, 'comment': <val>}}

Comment here is not required. You can change this behavior in reports.utils.ReportData.__get_type().

Actually, for validation for any row in the table there may be either "before fix" or "after fix" or they both, why not?.. During deciding a validation job table cells are fulfilled step by step. But even after finishing a validation job decision there still can be empty cells. I fixed the mentioned function appropriately in 8d59ad69 to branch new-report-data.

BTW, this all is a first step towards #8436. When it will be implemented we will have another way to visualize various verification results.

Actions

Copy link

Updated by Evgeny Novikov over 6 years ago

Status changed from Resolved to Open

An unexpected consequence is that I couldn't upload any verification job archive without specifying parent identifier. I hope that this can be trivially fixed.

Actions

Copy link

#10

Updated by Evgeny Novikov over 6 years ago

Evgeny Novikov wrote:

An unexpected consequence is that I couldn't upload any verification job archive without specifying parent identifier. I hope that this can be trivially fixed.

Ditto for archives of verification job trees.

Actions

Copy link

#11

Updated by Vladimir Gratinskiy over 6 years ago

Evgeny Novikov wrote:

Evgeny Novikov wrote:

An unexpected consequence is that I couldn't upload any verification job archive without specifying parent identifier. I hope that this can be trivially fixed.

Ditto for archives of verification job trees.

Fixed.

Actions

Copy link

#12