Feature #7164
closedSupport for inlined creation and editing of unsafe marks
Added by Evgeny Novikov almost 8 years ago. Updated about 7 years ago.
100%
Description
Now users are redirected to a dedicated page to create/edit a new/existing unsafes mark. Although that page has many advanced settings like attributes, functions and so on it lacks a visualized error trace while one would like to copy-paste some parts of an error trace or referenced source code.
I assume that a very lightweight unsafe marks creation/editing function can be inlined directly into the unsafe page. This function should include just the following fields:- verdict,
- status,
- tags,
- description.
To create a new unsafes mark in the lightweight manner you can add a new button near the current button for creating marks.
This feature was already requested by various people.
Files
| comments.png (45.1 KB) comments.png | Alexey Khoroshilov, 04/29/2016 12:08 AM | ||
| attributes.png (135 KB) attributes.png | Alexey Khoroshilov, 04/29/2016 12:08 AM |
Updated by Alexey Khoroshilov almost 8 years ago
- File attributes.png attributes.png added
- File comments.png comments.png added
I would suggest to inline the whole mark creation page to the error trace one and to place it below attributes that should occupy the whole width of a screen. Current cutting of the attributes table looks awful:
as well as comments to functions:
Updated by Evgeny Novikov about 7 years ago
- Priority changed from High to Urgent
Let's treat this issue next as highly desirable.
Updated by Evgeny Novikov about 7 years ago
- Subject changed from Support for inlined creation of unsafe marks to Support for inlined creation and editing of unsafe marks
- Description updated (diff)
Updated by Evgeny Novikov about 7 years ago
In addition, as it was discussed at #7926, descriptions should be shown for marks. You need to restrict corresponding field sizes reasonably (say, 3 lines in height and the maximum available width) by adding scroll bars.
Updated by Vladimir Gratinskiy about 7 years ago
- Due date set to 02/15/2017
- Status changed from New to Resolved
- % Done changed from 0 to 100
Implemented in branch "feature_7164".
Updated by Evgeny Novikov about 7 years ago
- Status changed from Resolved to Open
- When creating fullweight Unsafe marks Bridge opens a new tab in a browser rather than opens a new page within the same tab as it was before.
- At the Unsafe page mark descriptions are shown as pop ups while this isn't convenient. I suppose to show 3 first lines of these descriptions. In addition I suppose to make an associated marks table to occupy the whole screen by width. The button with attributes can be placed after this table.
- Changes in associations between reports and marks aren't shown when creating/editing lightweight marks.
Updated by Vladimir Gratinskiy about 7 years ago
Evgeny Novikov wrote:
I found a couple of issues:
- When creating fullweight Unsafe marks Bridge opens a new tab in a browser rather than opens a new page within the same tab as it was before.
OK.
- At the Unsafe page mark descriptions are shown as pop ups while this isn't convenient. I suppose to show 3 first lines of these descriptions. In addition I suppose to make an associated marks table to occupy the whole screen by width. The button with attributes can be placed after this table.
Why only 3 lines of description? I will show the whole description, and attributes table is not hidden under the button. If you then complain about scrolling I would do with it nothing.
- Changes in associations between reports and marks aren't shown when creating/editing lightweight marks.
How you want me to show? One more page merged with error trace page? Redirect to page with associations? It isn't convenient. Users want just to create the mark. If they want changes, let they create fullweight marks.
Updated by Evgeny Novikov about 7 years ago
Vladimir Gratinskiy wrote:
Evgeny Novikov wrote:
I found a couple of issues:
- At the Unsafe page mark descriptions are shown as pop ups while this isn't convenient. I suppose to show 3 first lines of these descriptions. In addition I suppose to make an associated marks table to occupy the whole screen by width. The button with attributes can be placed after this table.
Why only 3 lines of description? I will show the whole description, and attributes table is not hidden under the button. If you then complain about scrolling I would do with it nothing.
If you will show attributes outside of the error trace page screen nobody will complain since they are already opened so that one has to scroll down to see the complete list of them. Also I think that showing the whole descriptions is also quite good since ideally there should be the only associated mark per each unsafe (error trace). And in the most cases this is already the case.
- Changes in associations between reports and marks aren't shown when creating/editing lightweight marks.
How you want me to show? One more page merged with error trace page? Redirect to page with associations? It isn't convenient. Users want just to create the mark. If they want changes, let they create fullweight marks.
Redirecting will be perfect like with fullweight mark creation/editing. In addition at the association changes page there should be an ability to return back to the error trace page quickly.
Updated by Vladimir Gratinskiy about 7 years ago
- Status changed from Open to Resolved
Evgeny Novikov wrote:
Vladimir Gratinskiy wrote:
Evgeny Novikov wrote:
I found a couple of issues:
- At the Unsafe page mark descriptions are shown as pop ups while this isn't convenient. I suppose to show 3 first lines of these descriptions. In addition I suppose to make an associated marks table to occupy the whole screen by width. The button with attributes can be placed after this table.
Why only 3 lines of description? I will show the whole description, and attributes table is not hidden under the button. If you then complain about scrolling I would do with it nothing.
If you will show attributes outside of the error trace page screen nobody will complain since they are already opened so that one has to scroll down to see the complete list of them. Also I think that showing the whole descriptions is also quite good since ideally there should be the only associated mark per each unsafe (error trace). And in the most cases this is already the case.
I fixed the issue. But if you want to understand me about scrolling, add two marks or set the description of the mark in html form with "h1" html tag and then try to work with error trace: open functions, eyes, scroll source code or scroll error trace and so on.
- Changes in associations between reports and marks aren't shown when creating/editing lightweight marks.
How you want me to show? One more page merged with error trace page? Redirect to page with associations? It isn't convenient. Users want just to create the mark. If they want changes, let they create fullweight marks.
Redirecting will be perfect like with fullweight mark creation/editing. In addition at the association changes page there should be an ability to return back to the error trace page quickly.
I've fixed issues with "back browser button", so from association changes page you can return to unsafe page. But you have to reload the page there if it is cached. Also you have link in the association changes table in column "Report". But it is handy if only one report is in the table.
Fixed.
Updated by Evgeny Novikov about 7 years ago
Vladimir Gratinskiy wrote:
Evgeny Novikov wrote:
Vladimir Gratinskiy wrote:
Evgeny Novikov wrote:
I found a couple of issues:
- At the Unsafe page mark descriptions are shown as pop ups while this isn't convenient. I suppose to show 3 first lines of these descriptions. In addition I suppose to make an associated marks table to occupy the whole screen by width. The button with attributes can be placed after this table.
Why only 3 lines of description? I will show the whole description, and attributes table is not hidden under the button. If you then complain about scrolling I would do with it nothing.
If you will show attributes outside of the error trace page screen nobody will complain since they are already opened so that one has to scroll down to see the complete list of them. Also I think that showing the whole descriptions is also quite good since ideally there should be the only associated mark per each unsafe (error trace). And in the most cases this is already the case.
I fixed the issue. But if you want to understand me about scrolling, add two marks or set the description of the mark in html form with "h1" html tag and then try to work with error trace: open functions, eyes, scroll source code or scroll error trace and so on.
I added 3 marks one with "h1" html tag and do not experience any issues with scrolling. Everything works exactly as expected.
- Changes in associations between reports and marks aren't shown when creating/editing lightweight marks.
How you want me to show? One more page merged with error trace page? Redirect to page with associations? It isn't convenient. Users want just to create the mark. If they want changes, let they create fullweight marks.
Redirecting will be perfect like with fullweight mark creation/editing. In addition at the association changes page there should be an ability to return back to the error trace page quickly.
I've fixed issues with "back browser button", so from association changes page you can return to unsafe page. But you have to reload the page there if it is cached. Also you have link in the association changes table in column "Report". But it is handy if only one report is in the table.
It works very good. I even don't need to update a page after using the browser button.
Updated by Evgeny Novikov about 7 years ago
- Status changed from Resolved to Open
- When creating lightweight marks existing marks aren't shown.
- Descriptions of marks aren't automatically wrapped. Using HTML can't be reliable since window sizes are unknown.
- The order of associated marks looks strange. For instance, for me it is so: a fullweight mark created 2 minutes ago, 4 ligthweight marks created a minute ago, 14 minutes ago, 11 minutes ago, 4 minutes ago.
Updated by Vladimir Gratinskiy about 7 years ago
Evgeny Novikov wrote:
Some more issues I didn't notice before:
- When creating lightweight marks existing marks aren't shown.
Fixed.
- Descriptions of marks aren't automatically wrapped. Using HTML can't be reliable since window sizes are unknown.
Not my problem. You wanted html - you got html.
- The order of associated marks looks strange. For instance, for me it is so: a fullweight mark created 2 minutes ago, 4 ligthweight marks created a minute ago, 14 minutes ago, 11 minutes ago, 4 minutes ago.
Fixed so now order is by last change date. Btw on a report page you don't see dates.
Updated by Evgeny Novikov about 7 years ago
- Status changed from Open to Resolved
Vladimir Gratinskiy wrote:
Evgeny Novikov wrote:
Some more issues I didn't notice before:
- When creating lightweight marks existing marks aren't shown.
Fixed.
Great!
- Descriptions of marks aren't automatically wrapped. Using HTML can't be reliable since window sizes are unknown.
Not my problem. You wanted html - you got html.
Sorry, I was wrong, descriptions are pretty wrapped (before I have too small description).
- The order of associated marks looks strange. For instance, for me it is so: a fullweight mark created 2 minutes ago, 4 ligthweight marks created a minute ago, 14 minutes ago, 11 minutes ago, 4 minutes ago.
Fixed so now order is by last change date. Btw on a report page you don't see dates.
Perfect! I remembered when I created marks and was surprised when they weren't shown in the corresponding order. To reveal dates I opened corresponding mark pages.
So, after all this issue is finally resolved and soon it will be merged to master.
Updated by Evgeny Novikov about 7 years ago
- Status changed from Resolved to Closed
I merged the branch to master in 54ec67d. So everybody will be able to create, to edit and to see amazing unsafe marks.