Klever

Fixed in bridge-2.0

Although, thanks to #8937 I can not break JSON files through editing them, I can replace JSON files with ones having an invalid format. Then Bridge allows to decide corresponding jobs with raising the following exception:

Expecting property name enclosed in double quotes: line 8 column 1 (char 152)
Traceback (most recent call last):
  File "/home/novikov/work/klever/bridge/service/utils.py", line 544, in __get_tasks_limits
    return json.load(fp)
  File "/usr/lib64/python3.6/json/__init__.py", line 299, in load
    parse_constant=parse_constant, object_pairs_hook=object_pairs_hook, **kw)
  File "/usr/lib64/python3.6/json/__init__.py", line 354, in loads
    return _default_decoder.decode(s)
  File "/usr/lib64/python3.6/json/decoder.py", line 339, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib64/python3.6/json/decoder.py", line 355, in raw_decode
    obj, end = self.scan_once(s, idx)
json.decoder.JSONDecodeError: Expecting property name enclosed in double quotes: line 8 column 1 (char 152)

After all schedulers fail as expected.

BTW, there are many various files in jobs. But just 2 of them are vital, job.json and tasks.json. So, I extended the issue from tasks.json to job.json as well.

Fixed in bridge-2.0 for all *.json files.

Please, make following changes in branch bridge-2.0-master!

I revealed that Python 3.5 can't handle in jobs.jobForm.UploadFilesTree#__check_jsons:

            with f.file.file as fp:
                try:
                    json.load(fp)

There is such the error: "the JSON object must be str, not 'bytes'".

Can you fix that?

Evgeny Novikov wrote:

Can you fix that?

Fixed.

Tests passed, so, I merged the branch to master in b8bda00ac.