Feature #7919
closed
Allow to create marks including not only model function calls but also callbacks as leaves
Added by Ilja Zakharov over 7 years ago.
Updated about 7 years ago.
Description
Bridge applies the same mark created with the default conversion and comparison criterion (that is model function call forests) for the following two unsafes:
http://ldvstore:8998/reports/unsafe/19477/ - no call of packet_create callback which is important
http://ldvstore:8998/reports/unsafe/53461/ - there is a call of packet_create that makes the mark incorrectly added for this trace.
Since, there is a call of a driver callback in the second trace it should be considered as a different from the first one.
- Tracker changed from Bug to Feature
- Subject changed from Bridge incorrectly applies a mark to Allow to create marks including not only model function calls but also callbacks as leaves
- Description updated (diff)
- Status changed from New to Resolved
Implemented in branch forests_with_callbacks.
- Status changed from Resolved to Closed
I merge the branch to master in 87f45f1. It works, but do not forget to use another criterion for converting (forests_callbacks) and comparing (forests_callbacks_compare) error traces in this case. Also you can update existing marks manually specifying the former (e.g. by copying from a new mark created with an appropriate criteria) and choosing the later for automatic comparison.
BTW, now the second error trace lacks an appropriate mark.
Also available in: Atom
PDF