Bug #7821
closed
Incorrectly visualized error trace function call stack padding
Added by Ilja Zakharov over 7 years ago.
Updated over 7 years ago.
Description
Function 'ldv_create_class' in the error trace is called from init but and an indent corresponds to the call from 'ldv_register_chrdev'.
Module and rule specification names: drivers/video/fb.ko linux:drivers:base:class
Kernel: 2.6.33.20
Files
- Category set to Tasks generation
First, I will check that this is not the problem of translating from the witness format and all necessary edges are given.
- Priority changed from High to Immediate
This issue can be an indicator that something very bad is done when witnesses are preprocessed. Since corresponding changes can't be reverted later easily they should be as safe as possible. This is especially important since soon we will perform very considerable launches.
- Assignee changed from Ilja Zakharov to Evgeny Novikov
This is actually just incorrect visualization rather than incorrect error trace representation. It happens when there are the following tricky consequence in the error trace:
- enter func_1
- enter func_2 and return func_1
- return func_2
I attached the complete archive with the error trace and referred source files for testing.
Although the issue isn't so crucial as it seemed before, it would be better to fix it since incorrect visualization discourages manual error trace analysis.
- Due date set to 01/14/2017
- Status changed from New to Resolved
- % Done changed from 0 to 100
Fixed in branch "fix_7821".
- Status changed from Resolved to Closed
Looks good (and even old error traces are properly visualized after this)! I merged the branch to master in 9ecc04c.
Also available in: Atom
PDF