Project

General

Profile

Feature #9088

Enable safe marks by default

Added by Evgeny Novikov 6 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Urgent
Category:
Bridge
Target version:
Start date:
07/11/2018
Due date:
% Done:

0%

Estimated time:
Published in build:

Description

When uploading safe marks by a manager failed, I revealed that safe marks are disabled by default. There is a special setting ENABLE_SAFE_MARKS set to False within bridge/common.py. Although everybody can easily set this setting to True, I assume that we can just get rid of it completely (i.e. remove this setting and change all places where it is used appropriately). It was introduced a long ago, when associating safe marks was extremely slow, but now this isn't the case anymore.

BTW this rule seems to be violated by preset safe marks that are populated without any restrictions. So, it isn't working well anyway.


Related issues

Related to Klever - Feature #9089: Investigate whether disabling safe marks matterClosed2018-07-11

History

#1 Updated by Evgeny Novikov 6 months ago

  • Related to Feature #9089: Investigate whether disabling safe marks matter added

#2 Updated by Evgeny Novikov 6 months ago

  • Target version changed from 1.1 to 2.0
  • Priority changed from Urgent to High

Let's Vladimir will do this after his vacation.

#3 Updated by Vladimir Gratinskiy 4 months ago

  • Status changed from New to Resolved

Implemented in bridge-2.0

#4 Updated by Evgeny Novikov 4 months ago

  • Priority changed from High to Urgent

#5 Updated by Evgeny Novikov 4 months ago

  • Status changed from Resolved to Closed

Tests passed, so, I merged the branch to master in b8bda00ac.

Also available in: Atom PDF