Project

General

Profile

Actions

Feature #9088

closed

Enable safe marks by default

Added by Evgeny Novikov over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Urgent
Category:
Bridge
Target version:
Start date:
07/11/2018
Due date:
% Done:

0%

Estimated time:
Published in build:

Description

When uploading safe marks by a manager failed, I revealed that safe marks are disabled by default. There is a special setting ENABLE_SAFE_MARKS set to False within bridge/common.py. Although everybody can easily set this setting to True, I assume that we can just get rid of it completely (i.e. remove this setting and change all places where it is used appropriately). It was introduced a long ago, when associating safe marks was extremely slow, but now this isn't the case anymore.

BTW this rule seems to be violated by preset safe marks that are populated without any restrictions. So, it isn't working well anyway.


Related issues 1 (0 open1 closed)

Related to Klever - Feature #9089: Investigate whether disabling safe marks matterClosedVladimir Gratinskiy07/11/2018

Actions
Actions #1

Updated by Evgeny Novikov over 6 years ago

  • Related to Feature #9089: Investigate whether disabling safe marks matter added
Actions #2

Updated by Evgeny Novikov over 6 years ago

  • Priority changed from Urgent to High
  • Target version changed from 1.1 to 2.0

Let's Vladimir will do this after his vacation.

Actions #3

Updated by Vladimir Gratinskiy about 6 years ago

  • Status changed from New to Resolved

Implemented in bridge-2.0

Actions #4

Updated by Evgeny Novikov about 6 years ago

  • Priority changed from High to Urgent
Actions #5

Updated by Evgeny Novikov about 6 years ago

  • Status changed from Resolved to Closed

Tests passed, so, I merged the branch to master in b8bda00ac.

Actions

Also available in: Atom PDF