Project

General

Profile

Actions

Feature #9089

closed

Investigate whether disabling safe marks matter

Added by Evgeny Novikov almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Urgent
Category:
Bridge
Target version:
Start date:
07/11/2018
Due date:
% Done:

0%

Estimated time:
Published in build:

Description

Everybody already forgets the time when associating safe marks were very-very slow even when there were not safe marks at all. Moreover, due to absence of proofs to be analyzed somehow, safe marks are still exotic, that can be useful in quite artificial cases, namely for testing and validation verification jobs that are obviously are out of the normal user workflow. In those days we had to disable safe marks either globally (enabled by default) or per individual verification jobs (also enabled by default). The first option is harmful, so, we will get rid of it soon (#9088). The second one needs some investigation. If highly loaded production servers will not suffer much from enabling safe marks for all verification jobs, we will be able to get rid of it completely.


Related issues 1 (0 open1 closed)

Related to Klever - Feature #9088: Enable safe marks by defaultClosedVladimir Gratinskiy07/11/2018

Actions
Actions #1

Updated by Evgeny Novikov almost 6 years ago

Actions #2

Updated by Evgeny Novikov almost 6 years ago

  • Description updated (diff)
Actions #3

Updated by Evgeny Novikov over 5 years ago

  • Category set to Bridge
  • Assignee set to Vladimir Gratinskiy
  • Priority changed from High to Urgent
  • Target version set to 2.0

As I see, you removed disabling safe marks at all during #9088. Vladimir, did you investigate how enabling/disabling safe marks influence various operations, like jobs uploading/downloading, when there are many large jobs and various marks?

Actions #4

Updated by Vladimir Gratinskiy over 5 years ago

Evgeny Novikov wrote:

As I see, you removed disabling safe marks at all during #9088. Vladimir, did you investigate how enabling/disabling safe marks influence various operations, like jobs uploading/downloading, when there are many large jobs and various marks?

Nope, I can't investigate it without some large jobs for testing.

Actions #5

Updated by Evgeny Novikov over 5 years ago

  • Status changed from New to Resolved

Vladimir Gratinskiy wrote:

Evgeny Novikov wrote:

As I see, you removed disabling safe marks at all during #9088. Vladimir, did you investigate how enabling/disabling safe marks influence various operations, like jobs uploading/downloading, when there are many large jobs and various marks?

Nope, I can't investigate it without some large jobs for testing.

Okay, let's hope that everything will operate quite fast, but if this will not be the case, we will need to quickly re-enable disabling safe marks.

Actions #6

Updated by Evgeny Novikov over 5 years ago

  • Status changed from Resolved to Closed

Tests passed, so, I merged the branch to master in b8bda00ac.

Actions

Also available in: Atom PDF