Feature #7962
closedDo not repeat the same tags for the same unsafe at unsafes list page
100%
Description
Alexey noted at https://forge.ispras.ru/issues/7960#note-1:
Tag set is a set, same tags coming from different sources (marks) should not be shown twice.
Updated by Vladimir Gratinskiy almost 8 years ago
- Due date set to 02/08/2017
- Status changed from New to Resolved
- % Done changed from 0 to 100
Fixed in "fix_tags_vis".
Updated by Evgeny Novikov almost 8 years ago
- Status changed from Resolved to Open
But now I understood that initial opinion wasn't so good as it seemed. Now at the job page nice statistics is shown with the number of tag representatives as well as a set of tags (nothing was changed in this branch). While at the unsafes list page there isn't so cool numbers - just a set of tags. If one will think about reasons why there are more than one tag representative, then one will perhaps understand that there are excessive or even duplicate marks to be joined together, or some mark comparison functions should be updated so that their associations will change appropriately.
Updated by Vladimir Gratinskiy almost 8 years ago
- Due date changed from 02/08/2017 to 02/13/2017
- Status changed from Open to Resolved
Fixed in fix_7962. Now the number of tags are shown in brackets (if this number is more than 1).
Updated by Evgeny Novikov almost 8 years ago
- Status changed from Resolved to Closed
Looks very nice and useful. I merged the branch to master in bc3b739.
Updated by Alexey Khoroshilov almost 8 years ago
- Status changed from Closed to Open
Why these numbers are required for users?
Updated by Evgeny Novikov almost 8 years ago
- Status changed from Open to Closed
I answered there https://forge.ispras.ru/issues/7962#note-2.
Updated by Alexey Khoroshilov almost 8 years ago
- Status changed from Closed to Open
Evgeny Novikov wrote:
But now I understood that initial opinion wasn't so good as it seemed. Now at the job page nice statistics is shown with the number of tag representatives as well as a set of tags (nothing was changed in this branch). While at the unsafes list page there isn't so cool numbers - just a set of tags. If one will think about reasons why there are more than one tag representative, then one will perhaps understand that there are excessive or even duplicate marks to be joined together, or some mark comparison functions should be updated so that their associations will change appropriately.
You look at marks only from one perspective. There are situation when duplication is not a good thing, but there are situations when it is ok. For example, if the trace contains several problems that are described by dedicated marks. It is a typical situation for MEA analysis. I do not see a good reason to confuse users with strange numbers. If there are reasons to inform users that there several marks for the same trace, we have to provide more appropriate interface for that.
Updated by Evgeny Novikov over 7 years ago
- Status changed from Open to Closed
This issue was fixed and now everything is in compliance. You are suggesting another view rather that is suitable for both a job page and an unsafes/safes list page (#8017).