Bug #5500
closed
[engine][testbench] possible bug in TestVhdlTestbenchPrinter engine id
Added by Sergey Smolov almost 10 years ago.
Updated almost 10 years ago.
Description
Strange code fragment has been found:
public static final String ENGINE_ID = "test-verilog-testbench-printer".intern();
public static final String ENGINE_ID =
I added this field because all TestVhdlTestbenchPrinter instances has the same engine ID, made it public to avoid manual typing of engine ID outside of the class and interned it to avoid literal replacement of this field in other classes.
But why does this variable contain "verilog" substring in the TestVhdlTestbenchPrinter???
Some kind of tangle, I think.
Similar bug has been found in ru.ispras.retrascope.engine.testbench.VhdlTestbench:
super(VerilogTestbench.ENTITY_TYPE_ID);
- Status changed from New to Resolved
- % Done changed from 0 to 100
Oops, I've overlooked it. Fixed.
- Description updated (diff)
- Status changed from Resolved to Verified
- Status changed from Verified to Closed
Also available in: Atom
PDF