C Instrumentation Framework

First version of this feature is available in commit 693bb78 of feature-3692 branch pushed to Aspectator submodule. You can consider results (file file) obtained for file test9.c and aspect test9.aspect as output format specification. Note that initialization of arrays of structures isn't supported still.

The following bugs occur while using this inforequest. More details in attachments.

Beginning from commit 00b8e7f in feature-3692 branch of Aspectator submodule initialization of simple/pointer/array variables is also supported. Also one can use "$" instead of array size in pointcuts to match arrays of any size.

These features required considerable changes in format, sorry for that. You can see new "specification" in attached files. I hope that they won't be changed so much in future.

BTW, drbd is processed well now.

Added in commit e28f037 of the master branch of LDV tools, in e0b4bea of CIF submodule and in commit bfe8a89 of Aspectator submodule.
Wait for night tests and reference launch results before closing.

Works fine for small and night regression tests as well as with reference launches for 32_7a rule model.

One unpleasant issue was discovered. If a function pointer is assigned to a structure field but a type of this structure field doesn't coincide with a type of the given function, then the compiler makes an explicit cast on assignment. When we try to call functions together with these casts the compiler inserts __builtin_trap instead these calls, that eventually causes failures.

To reproduce this you need to run (CIF before 63912d):

$(CIF) --aspect first_request.aspect --in ipmi_poweroff.c.macroinstrumented --out out --stage instrumentation

Structure field initialization
  Field name is 'set'
  Type is 'function pointer'
  Declaration is 'int (*%s)(char const *, struct kernel_param const *)'
  Pointed function return type declaration is 'int %s'
  Pointed function argument type declarations are 'char const *%s', 'struct kernel_param const *%s'
  Value is '( int (*)(char const *, struct kernel_param const *)) & set_param_ifnum'

Although these issues are issues in drivers and thus should be fixed there, we can't wait when this will be done. And sometimes that mechanism is used intentionally, e.g. to assign pointers to stub functions. The compiler doesn't complain about that.

I am going to implement a workaround - will disable printing of casts in corresponding cases. No regexps!

Fixed in the feature-3692 branch of the Aspectator submodule. The workaround touches, by the way, all other implicit/explicit casts as well. This should simplify parsing of source code querying answers, but may be a source of other issues. So, I am looking forward for a feedback from Ilja. For instance, regressions for all modules for one rule specifications and for modules subjected to the given issue for other rule specifications.

Reduce priority due to major issues were gone.