Feature #2750
open
107: Each module should provide module metadata, including license, author and description
Added by Evgeny Novikov over 12 years ago.
Updated almost 12 years ago.
Description
That is each module should have macro substitutions like following:
MODULE_AUTHOR("Comedi http://www.comedi.org");
MODULE_DESCRIPTION("Comedi low-level driver");
MODULE_LICENSE("GPL");
It's
specific:style class in our classifier. Model 107_1a is intended to find this issue.
Files
de9010a commit of our master branch adds support of 107_1a model, that fixes issue presented in commit adbbc36 of the linux-stable branch. It requires additional kernel set up since in default configuration we check (allmodconfig) there isn't staging driver support. I attach corresponding patches. Unfortunately, I couldn't find more appropriate way to do this. Other specific:style bugs cannot be verified with present LDV tools.
It seems that just a license is mandatory module metadata.
- Subject changed from Each module should provide module metadata, including license, author and description to 107: Each module should provide module metadata, including license, author and description
Patch attached is replacement for four patches attached early.
- Priority changed from High to Normal
Reduce priority until we'll decide that it's high actually.
- Assignee changed from Evgeny Novikov to Marina Makienko
IMHO, although this is a rather simple rule, we should investigate it a bit more, implement and test corresponding model and find bugs.
- % Done changed from 0 to 70
- Status changed from Open to Closed
- % Done changed from 70 to 50
The rule was closed because of absence of information about writing module_author, module_description and module_license.
1. Module_author is recommended to write for feedback, but it's not necessary, because the list of developers you can see in kernel.
2. Module_description is not necessary too, because many developers write description of driver in comments at the beginning of driver.
3. Module_license should be when the driver has gpl-functions(for module-license("GPL")). But there are many functions which don't need it.
- Status changed from Closed to Resolved
I guess that we should remove 107_1a model from model-db.xml, delete corresponding files and free 107_1a identifier for other rules before closing this feature request.
Also available in: Atom
PDF