Project

General

Profile

Actions
Copy link

Feature #2750

open

107: Each module should provide module metadata, including license, author and description

Added by Evgeny Novikov over 12 years ago. Updated almost 12 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Marina Makienko
Start date:
04/13/2012
Due date:
% Done:

50%

Estimated time:
Published in build:

Description

That is each module should have macro substitutions like following:

MODULE_AUTHOR("Comedi http://www.comedi.org");
MODULE_DESCRIPTION("Comedi low-level driver");
MODULE_LICENSE("GPL");

It's specific:style class in our classifier. Model 107_1a is intended to find this issue.

Files

Download all files
2.6.37.2.drivers_staging.patch (1.94 KB) 2.6.37.2.drivers_staging.patch Patch of drivers/staging/Kconfig for 2.6.37.2 Evgeny Novikov, 04/13/2012 05:22 PM
2.6.37.2.drivers_staging_comedi.patch (1.24 KB) 2.6.37.2.drivers_staging_comedi.patch Patch of drivers/staging/comedi/Kconfig for 2.6.37.2 Evgeny Novikov, 04/13/2012 05:22 PM
2.6.37.3.drivers_staging.patch (1.95 KB) 2.6.37.3.drivers_staging.patch Patch of drivers/staging/Kconfig for 2.6.37.3 Evgeny Novikov, 04/13/2012 05:22 PM
2.6.37.3.drivers_staging_comedi.patch (1.24 KB) 2.6.37.3.drivers_staging_comedi.patch Patch of drivers/staging/comedi/Kconfig for 2.6.37.3 Evgeny Novikov, 04/13/2012 05:22 PM
107_1a.patch (2.15 KB) 107_1a.patch Evgeny Novikov, 04/26/2012 02:17 PM
Actions
Copy link Download all files
 #1

Updated by Evgeny Novikov over 12 years ago

de9010a commit of our master branch adds support of 107_1a model, that fixes issue presented in commit adbbc36 of the linux-stable branch. It requires additional kernel set up since in default configuration we check (allmodconfig) there isn't staging driver support. I attach corresponding patches. Unfortunately, I couldn't find more appropriate way to do this. Other specific:style bugs cannot be verified with present LDV tools.

Actions
Copy link
 #2

Updated by Evgeny Novikov over 12 years ago

It seems that just a license is mandatory module metadata.

Actions
Copy link
 #3

Updated by Alexey Khoroshilov about 12 years ago

  • Subject changed from Each module should provide module metadata, including license, author and description to 107: Each module should provide module metadata, including license, author and description
Actions
Copy link
 #4

Updated by Evgeny Novikov about 12 years ago

Patch attached is replacement for four patches attached early.

Actions
Copy link
 #5

Updated by Evgeny Novikov about 12 years ago

  • Priority changed from High to Normal

Reduce priority until we'll decide that it's high actually.

Actions
Copy link
 #6

Updated by Evgeny Novikov about 12 years ago

  • Assignee changed from Evgeny Novikov to Marina Makienko

IMHO, although this is a rather simple rule, we should investigate it a bit more, implement and test corresponding model and find bugs.

Actions
Copy link
 #7

Updated by Marina Makienko about 12 years ago

  • % Done changed from 0 to 70
Actions
Copy link
 #8

Updated by Marina Makienko about 12 years ago

  • Status changed from Open to Closed
  • % Done changed from 70 to 50

The rule was closed because of absence of information about writing module_author, module_description and module_license.

1. Module_author is recommended to write for feedback, but it's not necessary, because the list of developers you can see in kernel.
2. Module_description is not necessary too, because many developers write description of driver in comments at the beginning of driver.
3. Module_license should be when the driver has gpl-functions(for module-license("GPL")). But there are many functions which don't need it.

Actions
Copy link
 #9

Updated by Evgeny Novikov almost 12 years ago

  • Status changed from Closed to Resolved

I guess that we should remove 107_1a model from model-db.xml, delete corresponding files and free 107_1a identifier for other rules before closing this feature request.

Actions
Copy link

Also available in: Atom PDF