Feature #2750
open107: Each module should provide module metadata, including license, author and description
50%
Description
That is each module should have macro substitutions like following:
MODULE_AUTHOR("Comedi http://www.comedi.org");
MODULE_DESCRIPTION("Comedi low-level driver");
MODULE_LICENSE("GPL");
It's specific:style class in our classifier. Model 107_1a is intended to find this issue.
Files
Updated by Evgeny Novikov over 12 years ago
- File 2.6.37.2.drivers_staging.patch 2.6.37.2.drivers_staging.patch added
- File 2.6.37.2.drivers_staging_comedi.patch 2.6.37.2.drivers_staging_comedi.patch added
- File 2.6.37.3.drivers_staging.patch 2.6.37.3.drivers_staging.patch added
- File 2.6.37.3.drivers_staging_comedi.patch 2.6.37.3.drivers_staging_comedi.patch added
de9010a commit of our master branch adds support of 107_1a model, that fixes issue presented in commit adbbc36 of the linux-stable branch. It requires additional kernel set up since in default configuration we check (allmodconfig) there isn't staging driver support. I attach corresponding patches. Unfortunately, I couldn't find more appropriate way to do this. Other specific:style bugs cannot be verified with present LDV tools.
Updated by Evgeny Novikov over 12 years ago
It seems that just a license is mandatory module metadata.
Updated by Alexey Khoroshilov over 12 years ago
- Subject changed from Each module should provide module metadata, including license, author and description to 107: Each module should provide module metadata, including license, author and description
Updated by Evgeny Novikov over 12 years ago
- File 107_1a.patch 107_1a.patch added
Patch attached is replacement for four patches attached early.
Updated by Evgeny Novikov over 12 years ago
- Priority changed from High to Normal
Reduce priority until we'll decide that it's high actually.
Updated by Evgeny Novikov over 12 years ago
- Assignee changed from Evgeny Novikov to Marina Makienko
IMHO, although this is a rather simple rule, we should investigate it a bit more, implement and test corresponding model and find bugs.
Updated by Marina Makienko over 12 years ago
- Status changed from Open to Closed
- % Done changed from 70 to 50
The rule was closed because of absence of information about writing module_author, module_description and module_license.
1. Module_author is recommended to write for feedback, but it's not necessary, because the list of developers you can see in kernel.
2. Module_description is not necessary too, because many developers write description of driver in comments at the beginning of driver.
3. Module_license should be when the driver has gpl-functions(for module-license("GPL")). But there are many functions which don't need it.
Updated by Evgeny Novikov over 12 years ago
- Status changed from Closed to Resolved
I guess that we should remove 107_1a model from model-db.xml, delete corresponding files and free 107_1a identifier for other rules before closing this feature request.