Feature #1715
closedExtend KB cache with calculated verdict
0%
Description
It was found out, that this is rather useful feature. First of all, let us clarify the problem. Each launch from statistics can be related with several KB records, that in turn may have different verdicts. So, for each launch should be calculated its Verdict on the basis of the following table (it's situated in stats-visualizer/vhosts/ldv-stats/application/views/scripts/stats/index.phtml now):
// TP FP UNK // TP TP INC TP // FP INC FP FP // UNK TP FP UNK // where TP is True positive, FP is False positive, UNK is Unknown and // INC is Inconclusive (the last cannot be specified by a user).
while Tag is just concatenation of corresponding tags.
It wasn't a problem to perform such calculations for 'Unsafe' page (first of all, because there isn't many unsafes in a task and they are separated from each other for the given page). But it becomes a problem for 'Index' page where can be shown many grouped unsafes - see issue #1639. Moreover it can be a problem for 'True positive', 'Inconclusive' and so on pages to be implemented in near future.
But both Verdict and Tag can be calculated in KB cache (re)calculating indeed. Then they will not be calculated each time when 'Unsafe', 'Index', 'False positive', etc. pages will be opened - just in case when KB will be changed. So, I assume to extend KB cache table with '*Verdict*' and '*Tag*' columns, and teach kb-recalc script to calculate them.
Any objections?
Updated by Evgeny Novikov almost 13 years ago
- Priority changed from Normal to High
Make high priority since without this issue another important issue #1639 cannot be implemented.
Updated by Pavel Shved almost 13 years ago
So, I assume to extend KB cache table with '*Verdict*' and '*Tag*' columns, and teach kb-recalc script to calculate them.
Any objections?
I'm surprised it haven't been already done...
Updated by Evgeny Novikov almost 13 years ago
Pavel Shved wrote:
So, I assume to extend KB cache table with '*Verdict*' and '*Tag*' columns, and teach kb-recalc script to calculate them.
Any objections?I'm surprised it haven't been already done...
It wasn't done because generally speaking this isn't improvement for all cases. But it seems that for us to see KB results is more important than to edit KB, so we can spend more time in KB editing while obtain generalized KB results faster.
Updated by Evgeny Novikov almost 13 years ago
- Status changed from Open to Resolved
- Published in build set to 3d5d5c2
Committed in 3d5d5c2 to knowledge-base-2.
Updated by Evgeny Novikov almost 13 years ago
I forget to add that we need to specify from root mysql console:
SET GLOBAL log_bin_trust_function_creators = 1;
to upload triggers schema to our databases. This definition works until mysql server is shut down.
The following lines inside /etc/my.cnf (openSUSE) in section [mysqld] works each time:
# This allows nonsuper users to create triggers and functions log_bin_trust_function_creators = 1
Updated by Pavel Shved almost 13 years ago
Please, add this to the MySQL section of source:INSTALL
Updated by Evgeny Novikov almost 13 years ago
- Published in build changed from 3d5d5c2 to d7cadec
It's done in commit d7cadec.
Updated by Evgeny Novikov almost 13 years ago
- Status changed from Resolved to Closed
It's in master now.