Project

General

Profile

Actions
Copy link

Bug #971

open

DEG: Incorrect order of seq_operations

Added by Alexey Khoroshilov over 13 years ago. Updated over 13 years ago.

Status:
New
Priority:
Normal
Assignee:
Vadim Mutilin
Category:
Environment Generation
Start date:
03/22/2011
Due date:
% Done:

0%

Estimated time:
Detected in build:
git
Platform:
Published in build:

Description

DEG generates incorrect order of seq_operations (include/linux/seq_file.h):
void * (*start) (struct seq_file *m, loff_t *pos);
void (*stop) (struct seq_file *m, void *v);
void * (*next) (struct seq_file *m, void *v, loff_t *pos);
int (*show) (struct seq_file *m, void *v);

Correct order is:

start;
if (start returns != NULL)
{
  show;
  for(;nondet;)
  {
    next;
    if (next returns != NULL)
    {
      show;
    }
  }
}
stop;

To be more precise we should insert the "code" above instead of seq_read() and seq_lseek().

See details here: Documentation/filesystems/seq_file.txt.

Actions
Copy link
 #1

Updated by Alexey Khoroshilov over 13 years ago

An example of false positive:
ldv-git:32_7:drivers/isdn/capi/kcapi_proc.c:linux-3.0-rc1

Actions
Copy link

Also available in: Atom PDF