Project

General

Profile

Actions

Bug #927

closed

Aspectator doesn't ensure uniqueness for auxiliary generated functions

Added by Evgeny Novikov over 13 years ago. Updated about 12 years ago.

Status:
Closed
Priority:
High
Category:
-
Start date:
03/11/2011
Due date:
% Done:

0%

Estimated time:
Detected in build:
svn
Platform:
Published in build:
0491d9a

Description

I noticed this when I have obtained more one problem from linking:

Linking globals named 'ldv_module_put_2': symbol multiply defined!

It comes because of different object files to be linked contains the same definition of the given function (and this function hasn't any storage class specifier)! We don't notice the problem earlier since module_put wasn't instrumented (see Bug #362). As for other functions they contain the static storage class specifier for called functions that automatically doesn't lead to the given problem.
I suggest simple obvious fix: always add the static storage class specifier for such auxiliary functions.
Note that there is no problems with actual model functions like ldv_module_put since RI takes care of it.]
The problem should be addressed in the coming aspectator porting.


Related issues 1 (0 open1 closed)

Blocks C Instrumentation Framework - Feature #2462: We should develop "rerouter" functionality inside CIFClosedEvgeny Novikov02/20/2012

Actions
Actions

Also available in: Atom PDF