Linux Driver Verification » Linux Kernel Safety RuleDB

The error in the Linux kernel was detected in testing this model on the core. It is in the "include/linux/usb/serial.h"

#ifndef __LINUX_USB_SERIAL_H
#define __LINUX_USB_SERIAL_H

#include <linux/kref.h>
#include <linux/mutex.h>
#include <linux/sysrq.h>
#include <linux/kfifo.h>

#define SERIAL_TTY_MAJOR    188    /* Nice legal number now */
#define SERIAL_TTY_MINORS    254    /* loads of devices :) */
#define SERIAL_TTY_NO_MINOR    255    /* No minor was assigned */

struct usb_serial_port {
    struct usb_serial    *serial;
    struct tty_port        port;
        ...
}

The struct tty_port is used in this file but not declared.

If you add
#include <linux/tty.h>
in this file, everything works.

It looks that USB serial drivers don't object against including tty.h header file each time before including usb/serial.h. So most likely this isn't an error and may be treated as made by design. Although may be in future kernel developers will include tty.h inside usb/serial.h as a small optimization.

Marina Makienko wrote:

The error in the Linux kernel was detected in testing this model on the core. It is in the "include/linux/usb/serial.h"

[...]

The struct tty_port is used in this file but not declared.

If you add
#include <linux/tty.h>
in this file, everything works.