C Instrumentation Framework

I guess that this was missed while migrating from LLVM based aspectator to the GCC based one. There is a comment in ldv-pointcut-matcher.c:

/* TODO!!! Don't forget to get set/get and arg size/name instrumentation from the
  function below. */
void
ldv_match_expr_2 (tree t);
void
ldv_match_expr_2 (tree t)
{
...
}

before: set (int e11)
{
  $arg1++;
}
before: get (int e11)
{
  $arg1--;
}

How syntax of set/get variable pointcuts differs from syntax of pointcuts for functions. And what $arg1 does mean?

Alexey Khoroshilov wrote:

[...]

How syntax of set/get variable pointcuts differs from syntax of pointcuts for functions. And what $arg1 does mean?

For set/get variable pointcut syntax is (pseudo grammar):

set|get ( var_decl )

call|execution ( func_decl )

$argN - is Nth argument of an auxiliary function to be created on pointcut matching. It isn't obvious in case of variable pointcut but can be used as a temporary solution. May be something like $var or $var_name would be better.