Project

General

Profile

Actions
Copy link

Feature #4360

open

150: Locking and unlocking SDIO bus

Added by Alexey Khoroshilov almost 11 years ago. Updated over 9 years ago.

Status:
Open
Priority:
Normal
Assignee:
-
Start date:
07/17/2013
Due date:
% Done:

0%

Estimated time:
Published in build:

Description

The main lock function is sdio_claim_host(), unlock function is sdio_release_host().
Other functions to be modeled should be identified across users of mmc_claim_host(), mmc_try_claim_host(), mmc_release_host().

This is an example of violation of this rule: 1575714

Actions
Copy link
 #1

Updated by Alexey Khoroshilov about 10 years ago

  • Status changed from New to Resolved

Implemented by Amr Shibiny during GSoC-2013, merged in master and released in LDV 0.5.

Actions
Copy link
 #2

Updated by Vitaly Mordan over 9 years ago

Unnecessary headers
#include <linux/mutex.h>
#include <linux/mmc/sdio_func.h>
#include <linux/mmc/host.h>
#include <linux/mmc/card.h>
#include <linux/wait.h>
may cause Aspectator to failed at 'instrumentation' stage (for example, module drivers/staging/rtl8712/r8712u.ko, kernel 3.16-rc1).

Actions
Copy link
 #3

Updated by Vitaly Mordan over 9 years ago

Headers
#include <linux/mmc/sdio_func.h>
#include <linux/mmc/host.h>
#include <linux/mmc/card.h>
are actually required (for example, for module drivers/mmc/card/sdio_uart.ko).

Actions
Copy link
 #4

Updated by Vadim Mutilin over 9 years ago

  • Description updated (diff)
Actions
Copy link
 #5

Updated by Alexey Khoroshilov over 9 years ago

  • Status changed from Resolved to Open

sdio_claim_host/mmc_claim_host supports nested claiming by the current thread.

So the following assert is not valid:

void ldv_sdio_claim_host(int dev_id)
{
  /* LDV_COMMENT_ASSERT Check if the bus hasn't been claimed before. */
  ldv_assert(ldv_sdio_element == 0);
Actions
Copy link

Also available in: Atom PDF