Actions
Feature #3608
open145: Usage of clock functions
Start date:
10/23/2012
Due date:
% Done:
30%
Estimated time:
Published in build:
Description
It is necessary to use functions from clk.h correctly. This rule checks usage of functions clk_get, clk_prepare, clk_enable, clk_disable, clk_unprepare, clk_put.
- functions must be in the correct order
- function clk_put mustn't get null pointerUpdated by Alexey Khoroshilov about 12 years ago
Are any known bugs of this kind?
Updated by Vladimir Gratinskiy about 12 years ago
Commit 0afe0f1 at linux-stable fix that clk_put receives null pointer. Other commits I didn't find yet.
Updated by Alexey Khoroshilov over 10 years ago
'clk_put mustn't get null pointer' is not actual requirement anymore.
The rule should be left to check correct usage of clk_ API (ordering, balancing, etc.), but it should not check for NULL pointers. So commit 0afe0f1 will be irrelevant to it.
Updated by Ilja Zakharov almost 10 years ago
- Status changed from New to Open
- Assignee changed from Vladimir Gratinskiy to Vadim Mutilin
Current rule implementation does not provide model for 'devm_clk_get', so it results into many false alarms.
Updated by Ilja Zakharov almost 10 years ago
Another not implemented yet function is 'clk_prepare'.
Actions