Project

General

Profile

Actions

Feature #2606

open

119: probe functions should not return -EINTR

Added by Alexey Khoroshilov over 12 years ago. Updated almost 12 years ago.

Status:
Open
Priority:
Normal
Start date:
03/17/2012
Due date:
% Done:

70%

Estimated time:
Published in build:

Description

On Fri, Mar 16, 2012 at 10:02 PM, Oliver Neukum wrote:

Indeed there's a lot wrong here. The idea of having an interruptible
sleep in probe() is arcane. You need a very, very, very good reason for that.

Can you please explain why interruptible sleep should not be in probe() ?
I am curious to know.

-EINTR is supposed to be returned to user space, so that it can repeat
an interrupted syscall.

- There is no user space for probe()
- probe() cannot be easily repeated from user space
- there is no syscall for probe


Related issues 1 (0 open1 closed)

Blocked by C Instrumentation Framework - Feature #3291: Speed up CIF essentiallyClosedIlya Shchepetkov07/26/2012

Actions
Actions #1

Updated by Alexey Khoroshilov over 12 years ago

  • Description updated (diff)
Actions #2

Updated by Vadim Mutilin over 12 years ago

Interesting rule. Could you put a link to original discussion to follow it

Actions #3

Updated by Vladimir Gratinskiy over 12 years ago

  • Subject changed from probe functions should not return -EINTR to 119: probe functions should not return -EINTR
  • Assignee set to Vladimir Gratinskiy
Actions #4

Updated by Vladimir Gratinskiy over 12 years ago

  • % Done changed from 0 to 40
Actions #5

Updated by Vladimir Gratinskiy over 12 years ago

  • % Done changed from 40 to 70
Actions #6

Updated by Vladimir Gratinskiy over 12 years ago

  • Status changed from New to Open
Actions #7

Updated by Evgeny Novikov almost 12 years ago

I will temporarily remove a regression test task for 119 model since it requires a lot of memory (see related #3291 issue) and sometimes breaks our QA server.

Actions

Also available in: Atom PDF