Bug #9847
closedKlever incorrectly shows coverage in libraries at visualization of error traces
0%
Description
Motivation example: drivers/uwb/hwa-rc.ko (linux:memory safety)
There is a library function "interface_to_usbdev" in source files/include/linux/usb.h at 613-616 lines.
Actual coverage from CPAchecker says that both lines and the function are covered but coverage JSON does not contain the coverage for this file at all. Thus, a user see misleading results.
Files
Updated by Ilja Zakharov over 4 years ago
- Category changed from Results processing to Bridge
- Assignee set to Vladimir Gratinskiy
Seems that reason of this issue is a bug in Bridge. Bridge at error trace visualization should not highlight with the red color any files which are not referred in coverage report. But it does it both for header files and outside C files which are not included into the verification task.
Updated by Evgeny Novikov over 4 years ago
Yes, we agreed that Bridge should show empty code coverage just for those source files that are presented in coverage statistics and for which there are zeroes. Other source files, that are reachable through cross references, should not be shown as non-covered. Otherwise, users do not understand code coverage semantics easily.
Updated by Evgeny Novikov over 4 years ago
Moreover, I suggest to show an explicit warning when users will reach source files without code coverage. This warning may be the following: "You can try another code coverage type to get code coverage for a given source file".
Updated by Vladimir Gratinskiy over 4 years ago
- Priority changed from Urgent to Normal
Implemented in klever-3.0, but without an explicit warning.
Updated by Evgeny Novikov over 4 years ago
- Status changed from New to Resolved
- Priority changed from Normal to Urgent
Okay, let's think about warnings one day later. There are many other places where some help for users is strictly necessary as well.
Updated by Evgeny Novikov over 4 years ago
- Precedes Feature #9866: Show warning when users will reach source files without code coverage added