Project

General

Profile

Feature #9768

Use built-in means for checking Clade directory

Added by Evgeny Novikov 10 months ago. Updated 4 months ago.

Status:
Closed
Priority:
High
Category:
Infrastructure of Core
Target version:
Start date:
07/24/2019
Due date:
% Done:

0%

Estimated time:
Published in build:

Description

Associated revisions

Revision 9ce6bf05 (diff)
Added by Ilya Shchepetkov 5 months ago

Use built-in means for checking Clade directory

Implements #9768

History

#1

Updated by Ilya Shchepetkov 6 months ago

Today Evgeny sent me the following error trace associated with Clade:

File "/home/novikov/work/klever/core/core/pfg/abstractions/__init__.py", line 355, in __divide
    for desc in (d for d in self.clade.compilation_cmds if d.get('out') and len(d.get('out')) > 0):
  File "/home/novikov/work/klever/venv/lib/python3.6/site-packages/clade/__init__.py", line 307, in compilation_cmds
    return [self.__normalize_cmd(cmd) for cmd in cmds]
  File "/home/novikov/work/klever/venv/lib/python3.6/site-packages/clade/__init__.py", line 307, in <listcomp>
    return [self.__normalize_cmd(cmd) for cmd in cmds]
  File "/home/novikov/work/klever/venv/lib/python3.6/site-packages/clade/__init__.py", line 702, in __normalize_cmd
    cmd["in"] = [self.Path.get_rel_path(cmd_in, cmd["cwd"]) for cmd_in in cmd["in"]]
  File "/home/novikov/work/klever/venv/lib/python3.6/site-packages/clade/__init__.py", line 702, in <listcomp>
    cmd["in"] = [self.Path.get_rel_path(cmd_in, cmd["cwd"]) for cmd_in in cmd["in"]]
  File "/home/novikov/work/klever/venv/lib/python3.6/site-packages/clade/extensions/path.py", line 61, in get_rel_path
    return self.get_rel_path(path, cwd, load_paths=True)
  File "/home/novikov/work/klever/venv/lib/python3.6/site-packages/clade/extensions/path.py", line 58, in get_rel_path
    raise RuntimeError

The reason of the error is that the installed version of Clade was incompatible with the build base. But as mentioned in this ticket, such incompatibility can be easily detected beforehand by using available Clade API described in https://github.com/17451k/clade/issues/108. It would be fairly easy to implement and benefits are clear, so I advise you to do it right away!

#2

Updated by Ilya Shchepetkov 5 months ago

  • Status changed from New to Resolved

Implemented in the clade-work-dir-ok branch.

#3

Updated by Evgeny Novikov 5 months ago

  • Target version set to 3.0
  • Assignee set to Ilya Shchepetkov
  • Status changed from Resolved to Verified
#4

Updated by Evgeny Novikov 4 months ago

  • Status changed from Verified to Closed

In master.

Also available in: Atom PDF