Project

General

Profile

Actions
Copy link

Feature #9193

open

Continue sorting out sync:race tests

Added by Evgeny Novikov over 5 years ago. Updated over 5 years ago.

Status:
New
Priority:
High
Assignee:
Pavel Andrianov
Category:
Testing
Target version:
-
Start date:
08/08/2018
Due date:
08/08/2018 (over 5 years late)
% Done:

0%

Estimated time:
Published in build:

Description

After #9099 there are still 13 C files in directory bridge/jobs/presets/testing rule specs/tests/sync/race/todo. Moreover, it seems that we need to clarify some ideal verdicts and preset marks as they are not correct at the moment. For instance, I noticed words true and false in variable names that may mean that corresponding unsafes are true and false correspondingly, while ideal verdicts and preset marks say that everything is perfect.

Related issues 1 (0 open — 1 closed)

Follows Klever - Feature #9099: Update CPALockatorClosedPavel Andrianov08/07/201808/07/2018

Actions
Actions
Copy link
 #1

Updated by Evgeny Novikov over 5 years ago

Actions
Copy link
 #2

Updated by Evgeny Novikov over 5 years ago

Actions
Copy link
 #3

Updated by Evgeny Novikov over 5 years ago

Actions
Copy link
 #4

Updated by Evgeny Novikov over 5 years ago

Actions
Copy link
 #5

Updated by Evgeny Novikov over 5 years ago

  • Due date set to 08/08/2018
  • Start date changed from 08/06/2018 to 08/08/2018
  • Follows Feature #9099: Update CPALockator added
Actions
Copy link
 #6

Updated by Pavel Andrianov over 5 years ago

Yes, the moved tests should be removed from /todo folder.

Ideal verdicts are also correct, as I think, except one case. Preparing an unsafe version of a benchmark I do not rename the variable. So, in the unsafe version there is a correct unsafe verdict for a variable ldv_false_unsafe.

Actions
Copy link
 #7

Updated by Evgeny Novikov over 5 years ago

Pavel Andrianov wrote:

Yes, the moved tests should be removed from /todo folder.

Ideal verdicts are also correct, as I think, except one case. Preparing an unsafe version of a benchmark I do not rename the variable. So, in the unsafe version there is a correct unsafe verdict for a variable ldv_false_unsafe.

So, please, prepare a corresponding branch that does all the best.

Actions
Copy link
 #8

Updated by Evgeny Novikov over 5 years ago

  • Target version changed from 2.0 to 3.0

Let's do this later.

Actions
Copy link
 #9

Updated by Evgeny Novikov over 5 years ago

  • Priority changed from Urgent to High
  • Target version deleted (3.0)

Although tests are very important, but let's do/fix them later.

Actions
Copy link

Also available in: Atom PDF