Project

General

Profile

Feature #9016

Show total similarity in unsafes and marks tables

Added by Ilja Zakharov 9 months ago. Updated 5 months ago.

Status:
Closed
Priority:
Urgent
Category:
Bridge
Target version:
Start date:
06/27/2018
Due date:
% Done:

0%

Estimated time:
Published in build:

Description

Currently it is difficult to detect unassociated marks or marks with low similarity. It is proposed to add an additional column in tables for unsafes and unsafe marks with total similarity value. New value is a sum of similarities of associated marks.

Job-8d5730c829.zip (1.19 MB) Job-8d5730c829.zip Evgeny Novikov, 10/05/2018 11:14 AM

Related issues

Related to Klever - Feature #9001: Dump similarities for associated unsafe marksClosed2018-06-25

History

#1 Updated by Evgeny Novikov 9 months ago

  • Related to Feature #9001: Dump similarities for associated unsafe marks added

#2 Updated by Evgeny Novikov 9 months ago

  • Target version changed from 2.0 to 1.1

This issue is not strictly bound with purposes of 2.0 that targets verification of C software.

#3 Updated by Evgeny Novikov 8 months ago

  • Target version changed from 1.1 to 2.0

Let's Vladimir will do this after his vacation.

#4 Updated by Vladimir Gratinskiy 6 months ago

  • Status changed from New to Resolved

Implemented in bridge-2.0

#5 Updated by Evgeny Novikov 6 months ago

  • Status changed from Resolved to Open

I see a new column for a table with unsafe marks, but not for a table with unsafes, where it is more required.

#6 Updated by Vladimir Gratinskiy 6 months ago

Evgeny Novikov wrote:

I see a new column for a table with unsafe marks, but not for a table with unsafes, where it is more required.

Implemented in bridge-2.0.

#7 Updated by Vladimir Gratinskiy 6 months ago

  • Status changed from Open to Resolved

#8 Updated by Evgeny Novikov 6 months ago

  • Status changed from Resolved to Closed

Tests passed, so, I merged the branch to master in b8bda00ac.

#9 Updated by Evgeny Novikov 6 months ago

For the attached job I still do not see total similarities in tables with unsafes.

Also, please, visualize similarities using percents rather than floats like for associated marks/unsafes at unsafe/mark pages.

#10 Updated by Vladimir Gratinskiy 5 months ago

  • Status changed from Open to Resolved

Evgeny Novikov wrote:

For the attached job I still do not see total similarities in tables with unsafes.

Also, please, visualize similarities using percents rather than floats like for associated marks/unsafes at unsafe/mark pages.

Fixed.

#11 Updated by Evgeny Novikov 5 months ago

  • Status changed from Resolved to Closed

Looks nice. I cherry picked the commit to master 2c6ef7e55.

#12 Updated by Evgeny Novikov 5 months ago

  • Status changed from Closed to Open

I found out one more issue. Bridge always shows total similarity <= 100% in the unsafe marks table even for marks with several associated reports. At least before when downloading JSON files with results total similarities were summed up, e.g. when there are 3 associated unsafes each with 100% similarity there was 300% total similarity or 3.0. I would like to have this behavior everywhere since it is strange to see total similarity 50% for a mark associated with 2 unsafes (one with 100% and another with 0%).

#13 Updated by Evgeny Novikov 5 months ago

  • Status changed from Open to Closed

I think more about this. Indeed the current representation is better, as one can easily detect partially associated marks even when there are several unsafes per a mark.

For downloaded JSON files it is better to remain everything as it was before implementation of this feature if something changed.

Also available in: Atom PDF