https://forge.ispras.ru/https://forge.ispras.ru/favicon.ico?16490126692018-06-25T15:46:32ZOpen-Source ProjectsKlever - Bug #8981: Visualization of error traces for generic:memory is brokenhttps://forge.ispras.ru/issues/8981?journal_id=334752018-06-25T15:46:32ZVladimir Gratinskiygratinskiy@ispras.ru
<ul><li><strong>File</strong> <a href="/attachments/5787">8981.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/5787/8981.png">8981.png</a> added</li><li><strong>Status</strong> changed from <i>New</i> to <i>Feedback</i></li></ul><p>It works in current master for me. Tested in Chrome and Firefox.</p> Klever - Bug #8981: Visualization of error traces for generic:memory is brokenhttps://forge.ispras.ru/issues/8981?journal_id=334782018-06-26T08:37:03ZEvgeny Novikovnovikov@ispras.ru
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Open</i></li></ul><p>I identified the source of the issue. Indeed, this is a strange consequence of adding license headers. In particular, the issue is due to a comment at the top of <em>reports/templates/reports/ETV_HideLink.html</em>. I do not understand, why you do not see it, but perhaps there is some platform dependent behavior.</p>
<p>After moving content of this file to the only place where it is included, the issue has gone, but I am not sure that it is a proper solution, so, wait for the one from you.</p> Klever - Bug #8981: Visualization of error traces for generic:memory is brokenhttps://forge.ispras.ru/issues/8981?journal_id=334802018-06-26T12:49:51ZVladimir Gratinskiygratinskiy@ispras.ru
<ul></ul><p>Try to comment with "{# #}" everywhere in templates and without adding new empty strings. I didn't see the problem because I used master before comments were added there.</p> Klever - Bug #8981: Visualization of error traces for generic:memory is brokenhttps://forge.ispras.ru/issues/8981?journal_id=334812018-06-26T12:54:52ZVladimir Gratinskiygratinskiy@ispras.ru
<ul></ul><p>Vladimir Gratinskiy wrote:</p>
<blockquote>
<p>Try to comment with "{# #}" everywhere in templates and without adding new empty strings. I didn't see the problem because I used master before comments were added there.</p>
</blockquote>
<p>I checked with "{# #}" and it doesn't work.</p> Klever - Bug #8981: Visualization of error traces for generic:memory is brokenhttps://forge.ispras.ru/issues/8981?journal_id=334822018-06-26T13:00:08ZVladimir Gratinskiygratinskiy@ispras.ru
<ul></ul><p>With these license comments each include adds comment to the page. It is not good idea to add license to templates.</p> Klever - Bug #8981: Visualization of error traces for generic:memory is brokenhttps://forge.ispras.ru/issues/8981?journal_id=334842018-06-26T13:07:21ZVladimir Gratinskiygratinskiy@ispras.ru
<ul></ul><p>I've found the solution. Comment with "{% comment '<Comment name>' <span>}<License>{</span> endcomment %}<temlate>" without adding new lines as I did it in "license-example" branch.</p> Klever - Bug #8981: Visualization of error traces for generic:memory is brokenhttps://forge.ispras.ru/issues/8981?journal_id=334852018-06-26T13:12:18ZEvgeny Novikovnovikov@ispras.ru
<ul></ul><p>Vladimir Gratinskiy wrote:</p>
<blockquote>
<p>I've found the solution. Comment with "{% comment '<Comment name>' <span>}<License>{</span> endcomment %}<temlate>" without adding new lines as I did it in "license-example" branch.</p>
</blockquote>
<p>Great. Do users download these comments or they are completely truncated during templates processing?</p> Klever - Bug #8981: Visualization of error traces for generic:memory is brokenhttps://forge.ispras.ru/issues/8981?journal_id=334882018-06-26T13:20:31ZVladimir Gratinskiygratinskiy@ispras.ru
<ul></ul><p>Evgeny Novikov wrote:</p>
<blockquote>
<p>Vladimir Gratinskiy wrote:</p>
<blockquote>
<p>I've found the solution. Comment with "{% comment '<Comment name>' <span>}<License>{</span> endcomment %}<temlate>" without adding new lines as I did it in "license-example" branch.</p>
</blockquote>
<p>Great. Do users download these comments or they are completely truncated during templates processing?</p>
</blockquote>
<p>They are truncated.</p> Klever - Bug #8981: Visualization of error traces for generic:memory is brokenhttps://forge.ispras.ru/issues/8981?journal_id=335012018-06-27T07:14:38ZEvgeny Novikovnovikov@ispras.ru
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-6 priority-high2 closed" href="/issues/8742">Bug #8742</a>: Name of copyright owner is incorrect</i> added</li></ul> Klever - Bug #8981: Visualization of error traces for generic:memory is brokenhttps://forge.ispras.ru/issues/8981?journal_id=335022018-06-27T07:18:32ZEvgeny Novikovnovikov@ispras.ru
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li></ul><p>I fixed the rest license headers in <a class="changeset" title="Fix license headers to truncate them during instatiating templates https://forge.ispras.ru/issue..." href="https://forge.ispras.ru/projects/klever/repository/331/revisions/d8801fde774b15020611ad3db634529eff6be23b">d8801fde</a>. There was the only place where the license header caused bad visualization. In other places there are empty lines in templates already, so some more did not cause any issues. Anyway, to reduce page sizes I followed your advice to use template-style comments rather than the HTML ones.</p>