Project

General

Profile

Feature #8702

'public static NodeValue.newBitVector(final boolean value)' convenience method

Added by Sergey Smolov about 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Andrei Tatarnikov
Category:
Expression
Target version:
Start date:
02/05/2018
Due date:
% Done:

100%

Estimated time:
Published in build:
0.4.32-beta-180820

History

#1

Updated by Andrei Tatarnikov about 2 years ago

  • Assignee changed from Andrei Tatarnikov to Sergey Smolov

In my opinion, this task is ambiguous. It is not clear to me what the following construct should mean: NodeValue.newBitVector(true, 4). It can be: 0001 or 1111?

I can implement method NodeValue.newBitVector(boolean), but it will return 1-bit vector (that is '1' or '0').
As for boolean-based bit vectors of arbitrary size, we need first to agree on some convention.

#2

Updated by Sergey Smolov about 2 years ago

  • Assignee changed from Sergey Smolov to Andrei Tatarnikov
  • Subject changed from 'public static NodeValue.newBitVector(final boolean value, final int size)' convenience method to 'public static NodeValue.newBitVector(final boolean value)' convenience method

Yes, it's ok for me to have the "NodeValue.newBitVector(boolean)" method only.
I've changed the feature header respectively.

#3

Updated by Andrei Tatarnikov about 2 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Resolved

Done in 0de32d2d.

#4

Updated by Sergey Smolov about 2 years ago

  • Status changed from Resolved to Verified
#5

Updated by Sergey Smolov over 1 year ago

  • Published in build set to 0.4.32-beta-180820
  • Status changed from Verified to Closed

Also available in: Atom PDF