Project

General

Profile

Bug #8666

Acquire locks when dealing when build commands cache

Added by Evgeny Novikov over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Urgent
Category:
Program fragments generation
Target version:
Start date:
01/15/2018
Due date:
% Done:

0%

Estimated time:
Detected in build:
svn
Platform:
Published in build:

Description

At the moment two methods core.lkvog.LKVOG#process_linux_kernel_build_cmd_desc and core.lkvog.LKVOG#_find_cc_full_desc_files_ operates with build commands cache linux_kernel_build_cmd_out_file_desc without any explicit locking while each of them performs several nonatomic actions. Maybe this can be a reason of extremely rare data races (e.g. #8664, although I'm not sure that was a data race...).

I suppose to explicitly acquire locks around all operations with shared dictionary. To do that it is most likely required to introduce multiprocessing.managers.SyncManager.Lock.


Related issues

Related to Klever - Feature #8664: Refactor relating build commandsRejected01/15/2018

Actions

History

#1

Updated by Evgeny Novikov over 1 year ago

  • Related to Feature #8664: Refactor relating build commands added
#2

Updated by Alexey Polushkin over 1 year ago

  • Status changed from New to Resolved

Resolved in branch 'lkvog_lock'

#3

Updated by Evgeny Novikov over 1 year ago

  • Target version changed from 2.0 to 1.0

Let's include this bug fix perhaps very useful into Klever version:0.3.

#4

Updated by Evgeny Novikov over 1 year ago

  • Status changed from Resolved to Closed

I merged this branch to master in 6d71b32 as a part of branch clean_dir2.

Also available in: Atom PDF