Project

General

Profile

Feature #8510

Update tests for multimodule verification

Added by Ilja Zakharov over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Urgent
Category:
Testing
Target version:
Start date:
10/19/2017
Due date:
% Done:

0%

Estimated time:
Published in build:

Description

As Evgeny updated the framework for tests in Klever we need to refresh all test suits and tests for multimodule verification is not an exception.

History

#1

Updated by Alexey Polushkin over 1 year ago

  • Status changed from New to Resolved

Resolved in branch 'multimodule_tests'

#2

Updated by Evgeny Novikov over 1 year ago

  • Status changed from Resolved to Open

After improving tests there are at least two failures because of ideal verdicts aren't known: "tests/several_groups/advanced/init.ko/linux:emg:test" and "tests/several_groups/closure/init.ko/linux:emg:test". Besides, there are two more strange failures, perhaps, due to some bugs in the testing framework. In general ~40% of all tests fail although before 100% tests passed.

Additional notes:
  • Remove test duplicates. I noticed that there are many such tests, e.g. all subdirectories in multimodule_error have the same content. Ditto for several other subdirectories.
  • Improve a tests coding style, e.g. do not place "{" at the same line as corresponding function declaration, add missed new lines between includes and declarations, etc.
  • In job.json:
    • Fix indentation.
    • Specify a default ideal verdict, e.g. "safe", and a default module, e.g. "init.ko", and do not specify them in corresponding sub-jobs.
#3

Updated by Alexey Polushkin over 1 year ago

  • Status changed from Open to Resolved

The branch 'multimodule_tests' has been updated

#4

Updated by Evgeny Novikov over 1 year ago

I used rule specification "test" instead of "linux:emg:test" and fixed numerous coding style issues. After that I merged that branch to branch tests in a380f207.

#5

Updated by Evgeny Novikov over 1 year ago

  • Status changed from Resolved to Closed

I merged branch tests to master in f96d83aa.

Also available in: Atom PDF