Project

General

Profile

Feature #8241

Reflect all changes at the association changes page

Added by Evgeny Novikov over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Urgent
Category:
Bridge
Target version:
Start date:
06/13/2017
Due date:
09/01/2017
% Done:

100%

Estimated time:
Published in build:

Description

At the moment not all changes in associations are properly shown at the association changes page. For instantce, if tags are changed there is change kind Changed but no changes are shown. The same issue is with associations with zero similarity: changes are reported but there isn't any differences (#8275).

Indeed all these issues are consequences of the original design of that page. It was developed to reflect just association changes not some extra information like changes of resulting verdict, tags, etc. Indeed the former isn't very interesting while the latter is of high interest. So you can even hide information on association changes that don't affect total expert evaluation (e.g. #8275 is one of such cases). The page can be renamed to something like "Total expert evaluation changes". If you still want to show association changes that don't affect total expert evaluation, you can show them at this page separately from the most interesting results.

History

#1

Updated by Evgeny Novikov about 3 years ago

  • Subject changed from Show tag changes at the association changes page to Reflect all changes at the association changes page
  • Description updated (diff)
  • Priority changed from High to Urgent
#2

Updated by Evgeny Novikov about 3 years ago

  • Target version set to 0.2
#3

Updated by Vladimir Gratinskiy about 3 years ago

  • Due date set to 09/01/2017
  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Evgeny Novikov wrote:

Indeed all these issues are consequences of the original design of that page. It was developed to reflect just association changes not some extra information like changes of resulting verdict, tags, etc.

I don't know what you meant under "etc" but showing tags changes are implemented in branch "feature_8241". Also I've added filter to hide associations that doesn't change total verdict or tags set. This filter is enabled by default.

#4

Updated by Evgeny Novikov about 3 years ago

  • Status changed from Resolved to Open

I suggest to show all existing/remaining tags in addition to added/removed once. After this one will be able to understand the situation in total quickly.

#5

Updated by Evgeny Novikov about 3 years ago

Evgeny Novikov wrote:

I suggest to show all existing/remaining tags in addition to added/removed once. After this one will be able to understand the situation in total quickly.

Perhaps they aren't shown due to the following exception:

Traceback (most recent call last):
  File "/home/novikov/work/klever/bridge/marks/views.py", line 518, in association_changes
    data = AssociationChangesTable(request.user, association_id, **view_add_args)
  File "/home/novikov/work/klever/bridge/marks/tables.py", line 875, in __init__
    self.values = self.__get_values()
  File "/home/novikov/work/klever/bridge/marks/tables.py", line 960, in __get_values
    if not self.__filter_row(report_id):
  File "/home/novikov/work/klever/bridge/marks/tables.py", line 1022, in __filter_row
    and self._data['values'][r_id]['tags'] is None:
KeyError: 'tags'

#6

Updated by Vladimir Gratinskiy about 3 years ago

  • Status changed from Open to Resolved

Fixed.

#7

Updated by Evgeny Novikov about 3 years ago

  • Status changed from Resolved to Closed

I merged the branch to master in 373b87c8.

Also available in: Atom PDF