https://forge.ispras.ru/https://forge.ispras.ru/favicon.ico?16490126692017-04-24T14:06:05ZOpen-Source ProjectsKlever - Feature #8147: Add support for preset unsafe and safe markshttps://forge.ispras.ru/issues/8147?journal_id=302412017-04-24T14:06:05ZEvgeny Novikovnovikov@ispras.ru
<ul><li><strong>Priority</strong> changed from <i>Urgent</i> to <i>Immediate</i></li></ul><p>Increase the issue priority since it blocks the high priority issue.</p> Klever - Feature #8147: Add support for preset unsafe and safe markshttps://forge.ispras.ru/issues/8147?journal_id=302932017-05-02T06:39:18ZEvgeny Novikovnovikov@ispras.ru
<ul><li><strong>Priority</strong> changed from <i>Immediate</i> to <i>Urgent</i></li></ul><p>This was the only immediate feature request. Let's use <em>immediate</em> just for crucial bugs.</p> Klever - Feature #8147: Add support for preset unsafe and safe markshttps://forge.ispras.ru/issues/8147?journal_id=303172017-05-03T13:23:25ZVladimir Gratinskiygratinskiy@ispras.ru
<ul><li><strong>Due date</strong> set to <i>05/03/2017</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Implemented in feature_8147.</p> Klever - Feature #8147: Add support for preset unsafe and safe markshttps://forge.ispras.ru/issues/8147?journal_id=303432017-05-04T12:12:35ZEvgeny Novikovnovikov@ispras.ru
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Open</i></li></ul><p>I met the following exception when I tried to edit an existing unsafe mark:<br /><pre>
Error while saving/creating mark: get() returned more than one MarkUnsafeHistory -- it returned 21!
Traceback (most recent call last):
File "/home/novikov/work/klever/bridge/marks/views.py", line 225, in save_mark
res = mutils.NewMark(request.user, savedata)
File "/home/novikov/work/klever/bridge/marks/utils.py", line 149, in __init__
self.mark = self.__new_mark()
File "/home/novikov/work/klever/bridge/marks/utils.py", line 195, in __new_mark
mark = res.change_mark(self._inst)
File "/home/novikov/work/klever/bridge/marks/UnsafeUtils.py", line 131, in change_mark
last_v = MarkUnsafeHistory.objects.get(version=F('mark__version'))
File "/home/novikov/.pyenv/versions/virtual-env-3.6.1/lib/python3.6/site-packages/django/db/models/manager.py", line 85, in manager_method
return getattr(self.get_queryset(), name)(*args, **kwargs)
File "/home/novikov/.pyenv/versions/virtual-env-3.6.1/lib/python3.6/site-packages/django/db/models/query.py", line 383, in get
(self.model._meta.object_name, num)
marks.models.MultipleObjectsReturned: get() returned more than one MarkUnsafeHistory -- it returned 21!
</pre></p> Klever - Feature #8147: Add support for preset unsafe and safe markshttps://forge.ispras.ru/issues/8147?journal_id=303442017-05-04T12:15:29ZEvgeny Novikovnovikov@ispras.ru
<ul></ul><p>Also I suggest to specify error trace <strong>patterns</strong> within unsafe marks themselves rather than within dedicated files since they won't be likely reused and they are quite compact.</p> Klever - Feature #8147: Add support for preset unsafe and safe markshttps://forge.ispras.ru/issues/8147?journal_id=303742017-05-05T12:35:28ZVladimir Gratinskiygratinskiy@ispras.ru
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Resolved</i></li></ul><p>Evgeny Novikov wrote:</p>
<blockquote>
<p>Also I suggest to specify error trace <strong>patterns</strong> within unsafe marks themselves rather than within dedicated files since they won't be likely reused and they are quite compact.</p>
</blockquote>
<p>Done. Also the exception was fixed.</p> Klever - Feature #8147: Add support for preset unsafe and safe markshttps://forge.ispras.ru/issues/8147?journal_id=304462017-05-26T08:33:45ZEvgeny Novikovnovikov@ispras.ru
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Open</i></li></ul><p>When I created a new mark its source is "Created". When I populated a new mark its source is "Preset". When I edited a populated mark its source is still "Preset". I suppose to change the latter to, say, "Edited preset".</p> Klever - Feature #8147: Add support for preset unsafe and safe markshttps://forge.ispras.ru/issues/8147?journal_id=304472017-05-26T09:16:10ZVladimir Gratinskiygratinskiy@ispras.ru
<ul></ul><p>Evgeny Novikov wrote:</p>
<blockquote>
<p>When I created a new mark its source is "Created". When I populated a new mark its source is "Preset". When I edited a populated mark its source is still "Preset". I suppose to change the latter to, say, "Edited preset".</p>
</blockquote>
<p>Let's add statuses "Edited just tags preset", "Edited just description preset", "Edited tags and status preset", "Edited tags created", "Edited tags, but revert changes uploaded" then? Why not?</p> Klever - Feature #8147: Add support for preset unsafe and safe markshttps://forge.ispras.ru/issues/8147?journal_id=304502017-05-26T09:39:35ZEvgeny Novikovnovikov@ispras.ru
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Resolved</i></li></ul><p>Vladimir Gratinskiy wrote:</p>
<blockquote>
<p>Evgeny Novikov wrote:</p>
<blockquote>
<p>When I created a new mark its source is "Created". When I populated a new mark its source is "Preset". When I edited a populated mark its source is still "Preset". I suppose to change the latter to, say, "Edited preset".</p>
</blockquote>
<p>Let's add statuses "Edited just tags preset", "Edited just description preset", "Edited tags and status preset", "Edited tags created", "Edited tags, but revert changes uploaded" then? Why not?</p>
</blockquote>
<p>Okay, let's think about such aspects of preset entities comprehensively next time. Indeed they are almost unused now (just created once during an initial population) like marks before, so there are much more questions that weren't asked yet. When we will use them more, we will encounter a lot of various problems.</p> Klever - Feature #8147: Add support for preset unsafe and safe markshttps://forge.ispras.ru/issues/8147?journal_id=304762017-05-26T13:36:40ZEvgeny Novikovnovikov@ispras.ru
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul><p>I merged the branch to master in <a class="changeset" title="Merge branch 'master' into feature_8106" href="https://forge.ispras.ru/projects/klever/repository/331/revisions/679f7706a1d4d36c23780d586805ade0b8f63381">679f7706</a>. Don't forget to migrate databases!</p>
<p>Now a way to keep not only validation and test tasks but also corresponding marks is open.</p>