Project

General

Profile

Actions

Bug #786

closed

Some models contain incorrect C code!

Added by Evgeny Novikov almost 14 years ago. Updated almost 14 years ago.

Status:
Closed
Priority:
Immediate
Category:
Rules and Models
Start date:
02/03/2011
Due date:
% Done:

0%

Estimated time:
Detected in build:
master
Platform:
Published in build:
master

Description

During fixing of #347 issue and making correct instrumentation for extern functions I found that some models have incorrect aspects. For example, 08_1 (comes from local testing) and 37_1 (comes from small regression test). The 37_1 model contains:

before: call(unsigned long probe_irq_on(void))
{
ldv_probe_irq_on()
}

what leads after instrumentation to:
long unsigned int ldv_probe_irq_on_1 (void)
{
  typedef long unsigned int ldv_func_ret_type;
  typedef void ldv_func_arg_type1;

ldv_probe_irq_on()

  return probe_irq_on();
}

But we must write correct C code inside advice bodies!


Related issues 1 (0 open1 closed)

Blocks C Instrumentation Framework - Bug #347: Aspectator fails with extern functions calls processingClosedEvgeny Novikov08/05/2010

Actions
Actions #1

Updated by Evgeny Novikov almost 14 years ago

I investigate the problem and found out that no more models except the specified 2 contains incorrect C code inside advice bodies (check just ';' after function calls). Check them and test now...

Actions #2

Updated by Evgeny Novikov almost 14 years ago

  • Status changed from Open to Resolved

Both fixed in master.
Please pay your attention! These models become working in the some way!

Actions #3

Updated by Evgeny Novikov almost 14 years ago

  • Published in build set to master
Actions #4

Updated by Evgeny Novikov almost 14 years ago

  • Status changed from Resolved to Closed

See no problems.

Actions

Also available in: Atom PDF