Project

General

Profile

Actions

Bug #7778

closed

Klever may fail on deleting Unsafe mark

Added by Vitaly Mordan over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Urgent
Category:
Bridge
Target version:
-
Start date:
12/06/2016
Due date:
12/06/2016
% Done:

100%

Estimated time:
Detected in build:
svn
Platform:
Published in build:

Description

During deleting mark (via Marks->Unsafes) the following error is occurred sometimes:

Internal Server Error: /marks/unsafe/
Traceback (most recent call last):
File "/usr/local/lib/python3.4/dist-packages/django/core/handlers/base.py", line 132, in get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/usr/local/lib/python3.4/dist-packages/django/contrib/auth/decorators.py", line 22, in wrapped_view
return view_func(request, *args, **kwargs)
File "/home/vitaly/klever/bridge/marks/views.py", line 305, in mark_list
'tabledata': MarksList(*table_args),
File "/home/vitaly/klever/bridge/marks/tables.py", line 400, in init
self.values = self.
_get_values()
File "/home/vitaly/klever/bridge/marks/tables.py", line 558, in _get_values
tag.tag.tag for tag in mark.versions.order_by('-version').first().tags.order_by('tag
_tag')
AttributeError: 'NoneType' object has no attribute 'tags'

At the same time, the mark is still deleted with this error message.

Actions #1

Updated by Evgeny Novikov over 7 years ago

  • Category set to Bridge
  • Assignee set to Vladimir Gratinskiy
  • Priority changed from Low to Urgent

This is a strange bug that can mean a big inconsistency.

Actions #2

Updated by Vladimir Gratinskiy over 7 years ago

Which branch?

Actions #3

Updated by Vitaly Mordan over 7 years ago

This bug was revealed in the branch "new_format_of_strategies", but it should present in master as well, since deleting mark was not changed in this branch "new_format_of_strategies".

Actions #4

Updated by Vitaly Mordan over 7 years ago

  • Description updated (diff)
Actions #5

Updated by Vladimir Gratinskiy over 7 years ago

  • Due date set to 12/06/2016
  • Status changed from New to Resolved
  • % Done changed from 0 to 100

I suppose the problem is trying to get list of marks during deleting (while mark's versions were deleted, but mark is still in the system).

I've fixed it in commit '6a2b8f5' of branch "better-unsafes-and-marks". Now before deleting the mark I set its version to 0, and everywhere when try to get marks I exclude such marks + response with error when try to do something with such marks. But anyway the actions with marks are locked during deleting. Only reading is available (getting list of marks, for example).

Actions #6

Updated by Ilja Zakharov over 7 years ago

  • Status changed from Resolved to Verified

Anyway it is merged already in 6e2305dc.

Actions #7

Updated by Ilja Zakharov over 7 years ago

  • Status changed from Verified to Closed
Actions

Also available in: Atom PDF