Project

General

Profile

Actions
Copy link

Feature #7667

closed

Environment specification for uart_ops structure

Added by Alexey Polushkin over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Urgent
Assignee:
Alexey Polushkin
Category:
Environment models
Target version:
-
Start date:
11/01/2016
Due date:
% Done:

0%

Estimated time:
Published in build:

Description

There is False Positive verdict for these drivers and rules:
drivers/tty/serial/sh-sci.ko clk2
drivers/tty/serial/sh-sci.ko clk1
drivers/tty/serial/st-asc.ko clk1
drivers/tty/serial/8250/8250.ko dma1
drivers/tty/serial/pch_uart.ko dma1

Required uart_ops specification for EMG

Actions
Copy link
 #1

Updated by Alexey Polushkin over 7 years ago

  • Status changed from New to Resolved

Implemented in 'serial_core_specs2' branch.

Verdict transitions are following:
drivers/tty/serial/sh-sci.ko clk2 UNSAFE -> TRUE_POSITIVE
drivers/tty/serial/sh-sci.ko clk1 UNSAFE -> TIMEOUT
drivers/tty/serial/st-asc.ko clk1 UNSAFE -> SAFE
drivers/tty/serial/8250/8250.ko dma1 UNSAFE -> TIMEOUT
drivers/tty/serial/pch_uart.ko dma1 UNSAFE -> TRUE_POSITIVE

Actions
Copy link
 #2

Updated by Evgeny Novikov over 7 years ago

  • Status changed from Resolved to Closed

Good job! I merged the branch to master in 27baa9e.

Actions
Copy link
 #3

Updated by Ilja Zakharov over 7 years ago

Evgeny, open the issue again, please.

There are still a couple of open issues:
  • Tests were not added to the proper job set - they have been added to the unsupported tests which are not run actually.
  • One need to add comments according to the new style specifications. As tests were not added to the proper job set I was not able to detect that comments are missing.
  • The same issue takes place concerning moving these tests to Linux 2.6.33 and 4.6.7 testing jobs.
Actions
Copy link
 #4

Updated by Evgeny Novikov over 7 years ago

  • Status changed from Closed to Open
  • Priority changed from Normal to Urgent

Let's do not leave these issues for a long time.

Actions
Copy link
 #5

Updated by Ilja Zakharov over 7 years ago

  • Status changed from Open to Resolved
  • Assignee changed from Alexey Polushkin to Ilja Zakharov

Fixed in better-unsafes-and-marks.

Actions
Copy link
 #6

Updated by Evgeny Novikov over 7 years ago

  • Tracker changed from Bug to Feature
  • Assignee changed from Ilja Zakharov to Alexey Polushkin

Let's keep the primary developer as an assigner. Since development and fixing of specifications is an infinite task, please, open specific issues when you will need something to improve/fix.

Actions
Copy link
 #7

Updated by Ilja Zakharov over 7 years ago

  • Status changed from Resolved to Closed

Merged in 6e2305dc.

Actions
Copy link

Also available in: Atom PDF