Project

General

Profile

Actions

Bug #7658

closed

Report error when analyzing error traces and connection is lost

Added by Evgeny Novikov over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Urgent
Category:
Bridge
Target version:
-
Start date:
10/31/2016
Due date:
11/16/2016
% Done:

100%

Estimated time:
Detected in build:
svn
Platform:
Published in build:

Description

Source files are downloaded and shown during error traces visualization just when they are required i.e. when one clicks a ink in an error trace that references a corresponding source file line. When connection is lost error trace visualizer does not say this when one tries to see some new source files. This looks strange causing users to think about some bugs in error traces generation or/and visualization.

Actions #1

Updated by Vladimir Gratinskiy over 7 years ago

  • Due date set to 11/16/2016
  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Fixed in commit "60fba63" of "better-unsafes-and-marks". Error notification will happen in case of any ajax error.

Actions #2

Updated by Evgeny Novikov over 7 years ago

  • Status changed from Resolved to Open

I didn't see any specific errors in the browser console as promised by corresponding pop-ups when, say, the error trace visualizer couldn't get new source file due to the connection was lost. When I click on source line number I always see just the following error message:

Пустая строка не может быть аргументом метода getElementById().jquery-2.1.4.min.js:2:24214

that doesn't depend on connection failures.
My browser is Firefox 49.0.2.

Actions #3

Updated by Vladimir Gratinskiy over 7 years ago

Evgeny Novikov wrote:

I didn't see any specific errors in the browser console as promised by corresponding pop-ups when, say, the error trace visualizer couldn't get new source file due to the connection was lost. When I click on source line number I always see just the following error message:
[...]
that doesn't depend on connection failures.
My browser is Firefox 49.0.2.

I suppose it is bug in firefox (it think that $('#' + v) is empty but it is not if v != '').

Concerning the bug I suppoose your browser use old javascript from cache. Or you click lines of already uploaded source code (there are no requests to server in this case), find others in your error trace.

Actions #4

Updated by Evgeny Novikov over 7 years ago

Vladimir Gratinskiy wrote:

Evgeny Novikov wrote:

I didn't see any specific errors in the browser console as promised by corresponding pop-ups when, say, the error trace visualizer couldn't get new source file due to the connection was lost. When I click on source line number I always see just the following error message:
[...]
that doesn't depend on connection failures.
My browser is Firefox 49.0.2.

I suppose it is bug in firefox (it think that $('#' + v) is empty but it is not if v != '').

Concerning the bug I suppoose your browser use old javascript from cache. Or you click lines of already uploaded source code (there are no requests to server in this case), find others in your error trace.

I switched off caches a long ago. Also I didn't see related sources, i.e. they weren't downloaded early (I switch off the network immediately after I just get the visualized error trace). I see pop-ups that say about ajax errors, but can't find something useful in any browser log or console. Can you try Firefox to specify where these errors can be actually found?

Actions #5

Updated by Vladimir Gratinskiy over 7 years ago

Evgeny Novikov wrote:

I switched off caches a long ago. Also I didn't see related sources, i.e. they weren't downloaded early (I switch off the network immediately after I just get the visualized error trace). I see pop-ups that say about ajax errors, but can't find something useful in any browser log or console. Can you try Firefox to specify where these errors can be actually found?

Logging is enabled when console is opened. So you should repeat action that led to error with opened console.

Actions #6

Updated by Evgeny Novikov over 7 years ago

Vladimir Gratinskiy wrote:

Evgeny Novikov wrote:

I switched off caches a long ago. Also I didn't see related sources, i.e. they weren't downloaded early (I switch off the network immediately after I just get the visualized error trace). I see pop-ups that say about ajax errors, but can't find something useful in any browser log or console. Can you try Firefox to specify where these errors can be actually found?

Logging is enabled when console is opened. So you should repeat action that led to error with opened console.

Of course I did that. I just see that some requests were made but there isn't any responses on them. Also there wasn't anything that looks like an error.

Actions #7

Updated by Vladimir Gratinskiy over 7 years ago

Evgeny Novikov wrote:

Vladimir Gratinskiy wrote:

Evgeny Novikov wrote:

I switched off caches a long ago. Also I didn't see related sources, i.e. they weren't downloaded early (I switch off the network immediately after I just get the visualized error trace). I see pop-ups that say about ajax errors, but can't find something useful in any browser log or console. Can you try Firefox to specify where these errors can be actually found?

Logging is enabled when console is opened. So you should repeat action that led to error with opened console.

Of course I did that. I just see that some requests were made but there isn't any responses on them. Also there wasn't anything that looks like an error.

I didn't find errors in firefox's console too. So I will change the message to "Ajax request error. Maybe connection refused".

Actions #8

Updated by Evgeny Novikov over 7 years ago

  • Status changed from Open to Resolved

Well, let's wait for better-unsafes-and-marks will be merged to master.

Actions #9

Updated by Ilja Zakharov over 7 years ago

  • Status changed from Resolved to Verified

Merged in 6e2305dc.

Actions #10

Updated by Ilja Zakharov over 7 years ago

  • Status changed from Verified to Closed
Actions

Also available in: Atom PDF