Project

General

Profile

Actions

Feature #7295

closed

Roll functions in the error trace by clicking a closing bracket

Added by Pavel Andrianov almost 8 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Immediate
Category:
Bridge
Target version:
-
Start date:
06/16/2016
Due date:
11/16/2016
% Done:

100%

Estimated time:
Published in build:

Description

It is useful to have an ability to roll functions not only at the start but at the end, e.g. the closing bracket. If the function is very long and not so important, it takes much time to find its start and roll its body.

Actions #1

Updated by Evgeny Novikov almost 8 years ago

In addition we discussed that it has sense to get rid of braces in visualized error traces. This can be done since lines of error traces are strictly indented like, say, Python source code.

BTW, please, look at visualization of strictly indented source code in, say, PyCharm. You can try to do something like that (vertical lines for each block with arrows at the beginning and at the end to close that block) for error traces as well.

Actions #2

Updated by Evgeny Novikov over 7 years ago

  • Priority changed from Normal to Immediate

This is very welcome for users.

Actions #3

Updated by Vladimir Gratinskiy over 7 years ago

  • Due date set to 09/12/2016
  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Done in branch "feature_7295".

Actions #4

Updated by Evgeny Novikov over 7 years ago

After all the given branch was merged to better-unsafes-and-marks.

Actions #5

Updated by Evgeny Novikov over 7 years ago

  • Status changed from Resolved to Open

I suggest to do one more step here. Can you place the closing symbol not on a separate line but on the last line of called functions? There are no such the lines for stack of functions leading to the error node, but for them I wouldn't like to see neither the closing bracket nor the closing symbol. These functions won't be likely closed any time since they are vital. Further improvements in error traces representation will likely hide by default the most of these functions somehow.

Actions #6

Updated by Vladimir Gratinskiy over 7 years ago

  • Due date changed from 09/12/2016 to 11/16/2016
  • Status changed from Open to Resolved

Implemented in branch "better-unsafes-and-marks". I've decided to hide some closing symbols by option. Closing symbols stays on their own line, and are not going to move to previous lines.

Actions #7

Updated by Ilja Zakharov over 7 years ago

  • Status changed from Resolved to Open

Confirm that it works for functions but it does not work for "eye" symbols.

Actions #8

Updated by Vladimir Gratinskiy over 7 years ago

Ilja Zakharov wrote:

Confirm that it works for functions but it does not work for "eye" symbols.

It supposed to be so. Functions with "eye" symbol can't be rolled, so the closing brackets are needed just to show the borders of functions' bodies.

Actions #9

Updated by Evgeny Novikov over 7 years ago

  • Status changed from Open to Closed

There are a lot of other ambiguous enhancements for error traces visualizations. Let's discuss them altogether.

Actions

Also available in: Atom PDF