Project

General

Profile

Actions
Copy link

Feature #7168

closed

Add support for model function call trees extraction and comparison criterion

Added by Evgeny Novikov almost 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
High
Assignee:
Vladimir Gratinskiy
Category:
Bridge
Target version:
-
Start date:
04/29/2016
Due date:
06/14/2016
% Done:

100%

Estimated time:
Published in build:
926dc80

Description

Using function call stacks for comparing error traces is very inaccurate. I suppose to use model function call trees, i.e. trees (but with the determined order of children) of function names where all leaves are model functions that are functions with notes (all such the functions should be necessary in these trees) while intermediate nodes constitute corresponding function call stacks (they can include model functions as well).

For instance, if the error trace looks like:

func1():
  ...
  func2():
    ...
    model_func1():
      ...
  model_func2():
    ...
  func3():
    model_func3():
      ...

then its function call tree will be the following:
               func1
  func2     model_func2    func3
model_func1             model_func3

(note that the order of children does matter).

Comparing error traces by model function call trees looks to be trivial for explanation.

I suppose to use new functions for extraction and comparison criterion by default.

Actions
Copy link
 #1

Updated by Evgeny Novikov almost 8 years ago

  • Priority changed from Urgent to High

There were already too many urgent issues for Vladimir.

Actions
Copy link
 #2

Updated by Vladimir Gratinskiy almost 8 years ago

  • Due date set to 06/14/2016
  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Done in branch "feature_7168". Set these function as default. You need just "population" to add them to existing database.

Actions
Copy link
 #3

Updated by Evgeny Novikov almost 8 years ago

  • Status changed from Resolved to Open

I don't know why, but simple call stack comparison doesn't work in this branch any more - error traces aren't associated with marks that used this criterion even if these marks are created on the basis of these error traces.

Actions
Copy link
 #4

Updated by Vladimir Gratinskiy almost 8 years ago

Evgeny Novikov wrote:

I don't know why, but simple call stack comparison doesn't work in this branch any more - error traces aren't associated with marks that used this criterion even if these marks are created on the basis of these error traces.

I can't reproduce this bug. Maybe you forgot to change error trace convertion function? This branch just add new functions and set them as default. These changes doesn't affect simple call stack functions. Population doesn't delete any associations and doesn't create new.

I offer to disable changing comparison function for mark because it depends on convertion function, which you can't change for existing marks.

Actions
Copy link
 #5

Updated by Evgeny Novikov almost 8 years ago

Yes, you are right twice. But let's think about functions bind in another issue (I agree that some ones do strictly bind, but the relation is many-to-many, besides users will be able to specify their own pattern error traces one day).

Actions
Copy link
 #6

Updated by Evgeny Novikov almost 8 years ago

  • Status changed from Open to Closed
  • Published in build set to 926dc80

I merged the branch to master in 926dc80.

Please, note that you need to populate new functions.

Actions
Copy link

Also available in: Atom PDF