Project

General

Profile

Feature #7167

Support for multiline patterns of unknown marks

Added by Evgeny Novikov almost 3 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Urgent
Category:
Bridge
Target version:
Start date:
04/29/2016
Due date:
10/25/2017
% Done:

100%

Estimated time:
Published in build:

Description

Now we can't use multiline patterns for unknown marks although sometimes it is useful.


Related issues

Blocks Klever - Feature #8171: Get rid of repeated unknowns during multimodule verificationClosed2017-11-13

History

#1 Updated by Evgeny Novikov over 1 year ago

  • Priority changed from Normal to Urgent
  • Target version set to 1.0

Raise the priority as it blocks the high priority issue.

#2 Updated by Vladimir Gratinskiy over 1 year ago

How should multiline marks work? Does it mean that in mark you can specify several functions?

First type:
If one of functions was matched with any string than the mark will be connected. That means that each regexp function must have the same set of groups so the pattern of problem will be correct for all of functions.

Second type:
When one line is matched with first function than the next line should be matched with second function and so one for mark to be connected with unknown report. This is more strict than current marks.

Third type:
Match all functions with all of lines and when I find all lines for each function then I will connect the mark.

Fourth type:
Like in 3d type I'm searching all matches in all lines for all functions. But like for unsafes I can introduce "similarity". And connect mark when at least one match was found (similarity > 0).

#3 Updated by Evgeny Novikov over 1 year ago

Vladimir Gratinskiy wrote:

How should multiline marks work? Does it mean that in mark you can specify several functions?

No, there will be a single function, namely regular expression, but it can contains new lines. At the moment pattern "a\nb" doesn't match failure description:

a
b

#4 Updated by Vladimir Gratinskiy over 1 year ago

  • Due date set to 10/25/2017
  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Implemented in branch "unknown-marks".

#5 Updated by Evgeny Novikov over 1 year ago

  • Status changed from Resolved to Closed

I tested this functionality and merged the branch to master in ce740c56.

Also available in: Atom PDF