Klever

Implemented in branch "unified-views".

I met the following exception:

Environment:

Request Method: GET
Request URL: http://localhost:8998/jobs/?&view=%7B%22columns%22%3A%5B%22role%22%2C%22author%22%2C%22date%22%2C%22status%22%2C%22unsafe%3Atotal%22%2C%22problem%3Atotal%22%2C%22safe%3Atotal%22%2C%22unsafe%22%5D%2C%22order%22%3A%5B%22up%22%2C%22date%22%5D%2C%22change_date%22%3A%5B%22older%22%2C%2210%22%2C%22weeks%22%5D%7D&view_type=1

Django Version: 1.11
Python Version: 3.6.1
Installed Applications:
('django.contrib.admin',
 'django.contrib.auth',
 'django.contrib.contenttypes',
 'django.contrib.humanize',
 'django.contrib.sessions',
 'django.contrib.messages',
 'django.contrib.staticfiles',
 'jobs',
 'marks',
 'reports',
 'service',
 'tools',
 'users')
Installed Middleware:
('django.contrib.sessions.middleware.SessionMiddleware',
 'django.middleware.locale.LocaleMiddleware',
 'django.middleware.common.CommonMiddleware',
 'django.middleware.csrf.CsrfViewMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'django.contrib.auth.middleware.SessionAuthenticationMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware',
 'django.middleware.clickjacking.XFrameOptionsMiddleware',
 'django.middleware.security.SecurityMiddleware')

Traceback:

File "/home/novikov/.pyenv/versions/virtual-env-3.6.1/lib/python3.6/site-packages/django/core/handlers/exception.py" in inner
  41.             response = get_response(request)

File "/home/novikov/.pyenv/versions/virtual-env-3.6.1/lib/python3.6/site-packages/django/core/handlers/base.py" in _legacy_get_response
  249.             response = self._get_response(request)

File "/home/novikov/.pyenv/versions/virtual-env-3.6.1/lib/python3.6/site-packages/django/core/handlers/base.py" in _get_response
  187.                 response = self.process_exception_by_middleware(e, request)

File "/home/novikov/.pyenv/versions/virtual-env-3.6.1/lib/python3.6/site-packages/django/core/handlers/base.py" in _get_response
  185.                 response = wrapped_callback(request, *callback_args, **callback_kwargs)

File "/home/novikov/.pyenv/versions/virtual-env-3.6.1/lib/python3.6/site-packages/django/contrib/auth/decorators.py" in _wrapped_view
  23.                 return view_func(request, *args, **kwargs)

File "/home/novikov/work/klever/bridge/tools/profiling.py" in wait
  133.                 res = f(*args, **kwargs)

File "/home/novikov/work/klever/bridge/jobs/views.py" in tree_view
  77.         'TableData': TableTree(request.user, **view_args)

File "/home/novikov/work/klever/bridge/jobs/JobTableProperties.py" in __init__
  105.         self.__collect_jobdata()

File "/home/novikov/work/klever/bridge/jobs/JobTableProperties.py" in __collect_jobdata
  263.         filters, unfilters = self.__view_filters()

File "/home/novikov/work/klever/bridge/jobs/JobTableProperties.py" in __view_filters
  350.             filters['name__' + self.view['title'][0]] = self.view['title'][1]

Exception Type: TypeError at /jobs/
Exception Value: 'NoneType' object is not subscriptable

In addition I increased the issue priority since important bug #8233 is fixed with it.

Fixed.

1. Use everywhere the same advanced method for selecting columns as at the jobs tree page. In addition, for some views new columns should be added, e.g. last change author/date for associated unsafe marks (I don't assume these columns should be shown by default, we just need an ability to show them).
2. Use everywhere the same method for setting filters (now at the job page it differs).
3. To reduce confusion I suggest to move everywhere sections intended for operations with named views upstairs. Indeed in the most cases users should switch between (shared) named views rather than setting their own ones.
4. Also I guess that views should be generally arranged and managed in the very similar way everywhere. For instance, now at the job page it is a bit different, e.g. another icon, no names "Columns" and "Filters".

Perhaps there is a bug in this branch for associated unsafe marks. Mark descriptions are placed within column "Association author" and so on.

Fixed issues you mentioned in last 2 comments. Don't forget to migrate (if you have views for associated marks table).

1. Now there isn't name "Filters" anymore which isn't clear. In addition at the job page there isn't any section name at all. I suggest to use "Data", "Filters" ("Hide..." can be treated as filters) and "Statistics".
2. Not all columns that could be filtered are allowed for filtering. For instance, at the unsafe marks page there isn't filter "last change date" neither when corresponding column is shown or not (by default). Perhaps there are similar problems for other views as well. I wouldn't like to add all possible filters but some ones should be added.
3. There isn't a view for the association changes page (as far as I remember it was mentioned even in the specification).
4. At the jobs tree page after opening the views menu the corresponding controlling element is shown after the views window not before it as for other pages.
5. The form for choosing ascending/descending order is aligned differently for different views, e.g. at the jobs tree page and at the unsafes page. Please, see other views as well.
6. Fix alignments of notes like "Enter the full name of the attribute, e.g. Linux kernel:Version". Various views are subjected to the given issue.
7. At the unsafe marks page the number of rows form is empty although 18 rows are shown as for other tables.

I've added new views for associations changes pages.

For me looks very well! So, I merged the branch to master in 9274ac98. Don't forget to migrate your databases.