Project

General

Profile

Actions
Copy link

Bug #5812

closed

Замена методов toString() на getLabel() (refactoring)

Added by Alexander Protsenko over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Sergey Smolov
Category:
Engine (Printer)
Target version:
0.1
Start date:
04/08/2015
Due date:
% Done:

100%

Estimated time:
Detected in build:
svn
Platform:
Published in build:
20150701

Description

В ru.ispras.retrascope.engine.efsm.printer.graphml:
Класс EfsmGraphMlVisitor использует в качестве получения параметра "заголовка" (label) данные с помощью методов toString().
А именно:

    Integer.toHexString(idState) + Integer.toString(modelId), state.toString(),

    GraphMlUtils.printNode(printWriter, guargId, guardedAction.getGuard().toString(),

    GraphMlUtils.printNode(printWriter, actionId, guardedAction.getAction().toString(),

Методы toString предлагается заменить аналогичными, например: getLabel(), которые и должны появится у классов указанных выше.

Actions
Copy link
 #1

Updated by Sergey Smolov over 9 years ago

  • Status changed from New to Open
  • Target version set to 0.1
Actions
Copy link
 #2

Updated by Sergey Smolov over 9 years ago

  • Status changed from Open to Resolved
  • % Done changed from 0 to 100

Done in r1759

Actions
Copy link
 #3

Updated by Alexander Protsenko over 9 years ago

Возможно стоит сделать так: перенести код toString() в getId(), а в toString() уже дергать getId().

А то выглядит своеобразно:

  public String getId() { return toString(); }

Actions
Copy link
 #4

Updated by Sergey Smolov over 9 years ago

Ok.
r1762

Actions
Copy link
 #5

Updated by Sergey Smolov over 9 years ago

  • Status changed from Resolved to Closed
  • Published in build set to 20150701
Actions
Copy link

Also available in: Atom PDF