Project

General

Profile

Bug #5500

[engine][testbench] possible bug in TestVhdlTestbenchPrinter engine id

Added by Sergey Smolov almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Category:
-
Target version:
Start date:
12/14/2014
Due date:
% Done:

100%

Estimated time:
Detected in build:
svn
Platform:
Published in build:

Description

Strange code fragment has been found:

public static final String ENGINE_ID = "test-verilog-testbench-printer".intern(); public static final String ENGINE_ID =

History

#1

Updated by Igor Melnichenko almost 6 years ago

I added this field because all TestVhdlTestbenchPrinter instances has the same engine ID, made it public to avoid manual typing of engine ID outside of the class and interned it to avoid literal replacement of this field in other classes.

#2

Updated by Sergey Smolov almost 6 years ago

But why does this variable contain "verilog" substring in the TestVhdlTestbenchPrinter???
Some kind of tangle, I think.

#3

Updated by Sergey Smolov almost 6 years ago

Similar bug has been found in ru.ispras.retrascope.engine.testbench.VhdlTestbench:

super(VerilogTestbench.ENTITY_TYPE_ID);
#4

Updated by Igor Melnichenko almost 6 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Oops, I've overlooked it. Fixed.

#5

Updated by Sergey Smolov almost 6 years ago

  • Description updated (diff)
  • Status changed from Resolved to Verified
#6

Updated by Sergey Smolov almost 6 years ago

  • Status changed from Verified to Closed

Also available in: Atom PDF