Bug #5280: C backend generates artificial structure declarators (field declarators) for unnamed structures and unions - C Instrumentation Framework - Open-Source Projects

Actions

Copy link

Bug #5280

closed

C backend generates artificial structure declarators (field declarators) for unnamed structures and unions

Added by Vadim Mutilin about 10 years ago. Updated about 10 years ago.

Status:

Closed

Priority:

High

Assignee:

Evgeny Novikov

Category:

Start date:

09/19/2014

Due date:

% Done:

Estimated time:

Detected in build:

old

Platform:

Published in build:

Description

The linker successfully process this issues, but it causes problems for static analysis tools with linking several files as far as the input files contain different generated field names for the same struct type name.

For CPAchecker it looks like

Error: Parsing failed (Cannot access field ldv_7819 in struct lockref in file btmrvl_debugfs_o_i in line 13373: ( * dentry ) . d_lockref . ldv_7819 (full line is return ( unsigned int ) ( * dentry ) . d_lockref . ldv_7819 . ldv_7818 . count;)) (EclipseCParser.buildCFA, SEVERE)

Example

LDV Tools f50982e, CPAchecker r13530 no_cil 
linux-3.17-rc1.tar.xz    32_7a drivers/bluetooth/btmrvl.ko    ldv_main1_sequence_infinite_withcheck_stateful

btmrvl_main.o.i:

struct lockref
{
# 33 "include/linux/lockref.h" 
  union
  {
# 32 "include/linux/lockref.h" 
    struct
    {
# 30 "include/linux/lockref.h" 
      spinlock_t lock;
      unsigned int count;
    } ldv_16557;
  } ldv_16558;
};

btmrvl_debugfs.o.i:

struct lockref
{
# 33 "include/linux/lockref.h" 
  union
  {
# 32 "include/linux/lockref.h" 
    struct
    {
# 30 "include/linux/lockref.h" 
      spinlock_t lock;
      unsigned int count;
    } ldv_7818;
  } ldv_7819;
};

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Vadim Mutilin about 10 years ago

See ticket 161 in CPAchecker project

Actions

Copy link

Updated by Evgeny Novikov about 10 years ago

Status changed from New to Open
Assignee set to Evgeny Novikov

It can be a duplicate of #1138, but I am not sure.

Actions

Copy link

Updated by Evgeny Novikov about 10 years ago

Priority changed from Normal to High

Actions

Copy link

Updated by Evgeny Novikov about 10 years ago

Tracker changed from Feature to Bug
Subject changed from C backend generates new names for unnamed structures and unions to C backend generates artificial structure declarators (field declarators) for unnamed structures and unions
Detected in build set to old

It is worth mentioning that GCC supports empty structure declarator lists while C-backend doesn't support them and this was the source of the given issue:

struct-declaration:
    specifier-qualifier-list struct-declarator-list ;

GNU extensions:

struct-declaration:
    specifier-qualifier-list

Actions

Copy link

Updated by Evgeny Novikov about 10 years ago

Status changed from Open to Resolved

Fixed in 2c42610 (besides I had to fix accesses and initialization of these unnamed fields). Please, test it during a week and close the issue if everything will work!

Actions

Copy link