Project

General

Profile

Actions

Bug #4401

closed

Fix C back-end warnings

Added by Evgeny Novikov over 11 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
High
Category:
C back-end
Start date:
07/28/2013
Due date:
% Done:

0%

Estimated time:
Detected in build:
svn
Platform:
Published in build:

Description

Although warnings aren't treated as errors, they may be very crucial. For instance, we run verification although C back-end produces incomplete code:

include/linux/printk.h: In function 'printk_skip_level': 
include/linux/printk.h:33:1: warning: LDV: ../../aspectator/gcc/c-family/ldv-convert.c: 3431: neither case nor default is catched [enabled by default] 
include/linux/printk.h:33:1: warning: LDV: ../../aspectator/gcc/c-family/ldv-convert.c: 3449: labeled statement wasn't converted [enabled by default] 
include/linux/printk.h:33:1: warning: LDV: ../../aspectator/gcc/c-family/ldv-pretty-print.c: 3195: labeled statement of statement was not printed [enabled by default]

First of all I would like to switch these warnings into errors since C back-end is mature enough to have no warnings.


Related issues 3 (0 open3 closed)

Blocked by C Instrumentation Framework - Bug #4911: C-backend fails to inline constantsRejectedEvgeny Novikov05/08/2014

Actions
Blocked by Linux Driver Verification - Bug #1173: 39_7: a lot of garbage in stdoutClosedPavel Shved05/05/2011

Actions
Blocked by C Instrumentation Framework - Bug #5430: C-backend doesn't support case range GNU extensionClosedEvgeny Novikov11/14/2014

Actions
Actions #1

Updated by Evgeny Novikov over 11 years ago

BTW, sometimes "-Werror" option is enabled for compilation commands in the Linux kernel. In this case all warnings are treated as errors automatically.

Actions #2

Updated by Evgeny Novikov about 10 years ago

This issue is important since CIF warnings account for a very huge final verification reports. As well they show noncritical bugs in rule specifications that can be actually critical because if we replace calls to kmalloc() with something that doesn't return anything, then we cut off considerable number of paths.

Actions #3

Updated by Evgeny Novikov almost 9 years ago

  • Subject changed from Fix Aspectator's and C-backend's warnings to Fix C back-end warnings
  • Description updated (diff)
  • Category set to C back-end
Actions #4

Updated by Evgeny Novikov over 5 years ago

  • Status changed from Open to Closed

Most warnings were fixed, and now warnings in C back-end are treated as errors, so nobody will miss them.

Actions

Also available in: Atom PDF