Project

General

Profile

Actions

Bug #1160

closed

New aspectator doesn't convert abs() function properly

Added by Pavel Shved over 13 years ago. Updated about 12 years ago.

Status:
Closed
Priority:
Normal
Category:
-
Start date:
05/03/2011
Due date:
% Done:

0%

Estimated time:
Detected in build:
svn
Platform:
Published in build:
0356a33 (aspect-gcc)

Description

Steps to reproduce:

LDV_DEBUG=30 ldv-manager rule_models=32_1a "envs=linux-2.6.31.6.tar.bz2" drivers=drivers/media/video/gspca/gspca_main.ko kernel_driver=1

The original source code looks like this:

steps = abs(desired_avg_lum - avg_lum) / deadzone;

but in the preprocessed aspectated sources we see:

# 2169 "/mnt/cluster/work/work/current--X--drivers/--X--test_newrilinux-2.6.31.6--X--32_1a/linux-2.6.31.6/csd_deg_dscv/1186/dscv_tempdir/dscv/ri/32_1a/drivers/media/video/gspca/gspca.c.p" 
  steps = ({
# 2169 "/mnt/cluster/work/work/current--X--drivers/--X--test_newrilinux-2.6.31.6--X--32_1a/linux-2.6.31.6/csd_deg_dscv/1186/dscv_tempdir/dscv/ri/32_1a/drivers/media/video/gspca/gspca.c.p" 
    int __x = desired_avg_lum - avg_lum;
# 2169 "/mnt/cluster/work/work/current--X--drivers/--X--test_newrilinux-2.6.31.6--X--32_1a/linux-2.6.31.6/csd_deg_dscv/1186/dscv_tempdir/dscv/ri/32_1a/drivers/media/video/gspca/gspca.c.p" 
    ( ( ( ( ( ( ( ( ( ( ( ) ) ) ) ) ) ) ) ) ) );
  } )


Related issues 2 (1 open1 closed)

Related to Linux Driver Verification - Bug #1167: Bugs related with 32_1a modelOpen05/03/2011

Actions
Related to C Instrumentation Framework - Bug #1158: GCC-aspectator re-defines integers instead of exportClosedEvgeny Novikov05/03/2011

Actions
Actions #1

Updated by Evgeny Novikov over 13 years ago

  • Status changed from New to Open

Most likely that this is associated with ABS_EXPR that I have never seen before and thus skipped it during C backend implementation.

Actions #2

Updated by Evgeny Novikov over 13 years ago

  • Priority changed from Normal to High

This bug may be rather important (see #1158).

Actions #3

Updated by Pavel Shved over 13 years ago

I added a new problem, and re-verified the report with it. It turned out that only 9 drivers report this kind of error (CBE_bad_node).

Actions #4

Updated by Evgeny Novikov over 13 years ago

  • Status changed from Open to Resolved
  • Priority changed from High to Normal
  • Published in build set to 0356a33 (aspect-gcc)

I have fixed on inertia even though it isn't so important.

Actions #5

Updated by Pavel Shved over 13 years ago

I performed another launch of the new aspectator, and it indeed doesn't make any drivers fail due to this issue.

The for this is named 'CBE_bad_node', but it's only relevant if it's the only cause of a driver failure.

Actions #6

Updated by Evgeny Novikov over 13 years ago

  • Status changed from Resolved to Closed

It works.

Actions #7

Updated by Evgeny Novikov about 12 years ago

  • Project changed from Linux Driver Verification to C Instrumentation Framework
  • Category deleted (15)
Actions

Also available in: Atom PDF