Project

General

Profile

Actions

Feature #10904

closed

Forbid empty aspects

Added by Evgeny Novikov 12 months ago. Updated 12 months ago.

Status:
Closed
Priority:
High
Category:
Tasks generation
Target version:
Start date:
08/14/2021
Due date:
% Done:

0%

Estimated time:
Published in build:

Description

Accidentally we revealed a bug when using an empty aspect. Weaver failed because of this empty aspect was first in the list of aspects for concatenation while it examined the last line from all aspects to append a new line symbol for files that do not end up with it. From the other side, it has no sense to provide empty aspects at all since they just occupy redundant place and do nothing useful. Some users can think that all C models should have the appropriate aspects, but this is not the case. If one does not need to weave in anything, e.g. when one provide function definitions for external undefined functions, it is enough to develop C models without aspects.

Actions #1

Updated by Evgeny Novikov 12 months ago

  • Status changed from New to Resolved

I implemented this issue in branch forbid-empty-aspects. BTW, Core will fail just when somebody will provide empty aspects for models. If empty aspects will be generated by some Core components, Weaver will skip them silently. Let's wait for CI.

Actions #2

Updated by Evgeny Novikov 12 months ago

  • Status changed from Resolved to Closed

Tests passed, so, I merged the branch to master in 453f00506. BTW, all aspects included into the Klever repository are not empty since they at least have the copyright header. The error could happen during development under quite specific conditions as I pointed out in the issue description.

Actions

Also available in: Atom PDF