Project

General

Profile

Bug #10708

EMG misses deregistration of pm_ops in remove

Added by Pavel Andrianov 3 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Urgent
Assignee:
Category:
Environment models
Target version:
Start date:
02/09/2021
Due date:
% Done:

0%

Estimated time:
Detected in build:
git
Platform:
Published in build:

Description

After successful probe of the platform_device, pm_ops are also registered. But after removing it, pm_ops are just suspended (in environment model). For races it means, that pm_ops thread is still active and the next probe operation will work in parallel with the first pm_ops. So, a normal deregistration of pm_ops (with pthread_join inside for races) is required.

#1

Updated by Pavel Andrianov 3 months ago

  • Status changed from New to Resolved

After Ilya's fixes the problem disappeared. Mark as resolved. If Ilya says, that the fix is final, it should be closed.

#2

Updated by Ilja Zakharov 3 months ago

I will add more pydoc annotations to the code in the next few days without changing any functional code. So you can begin testing the branch before considering its merge to the master branch.

#3

Updated by Evgeny Novikov 3 months ago

  • Target version set to 3.1
  • Priority changed from Normal to Urgent
  • Status changed from Resolved to Open

There is neither information on a branch where this bug was fixed nor information on a large improvement in progress. There is no much sense to test it prior to the end.

#4

Updated by Ilja Zakharov 2 months ago

  • Status changed from Open to Resolved

Prepared the branch finally: emg-new-abstraction

#5

Updated by Evgeny Novikov 2 months ago

  • Status changed from Resolved to Open

There are degradations shown by CI.

#6

Updated by Evgeny Novikov 2 months ago

  • Status changed from Open to Resolved

Ilja seems to fix all regressions. Let's see.

#7

Updated by Evgeny Novikov 2 months ago

  • Status changed from Resolved to Closed

After some more fixes, tests passed, so, I merged the branch to master in 0975f23d1.

Also available in: Atom PDF