Actions
Bug #10596
closedUse of unitialized CPU cores number
Start date:
11/26/2020
Due date:
% Done:
0%
Estimated time:
Detected in build:
git
Platform:
Published in build:
Description
Recent changes in NativeScheduler resulted in there may be use of unitialized CPU cores number when "disable CPU cores account" is set to false in the configuration file (that is the default value overwritten by deployment scripts):
root ERROR> Uncaught exception Traceback (most recent call last): File "/home/novikov/work/klever/venv/bin/klever-native-scheduler", line 11, in <module> load_entry_point('klever', 'console_scripts', 'klever-native-scheduler')() File "/home/novikov/work/klever/klever/scheduler/main.py", line 56, in native_scheduler scheduler_impl = Scheduler(conf, logger, "scheduler/", native.Native) File "/home/novikov/work/klever/klever/scheduler/schedulers/__init__.py", line 111, in init self.init_scheduler() File "/home/novikov/work/klever/klever/scheduler/schedulers/__init__.py", line 135, in init_scheduler self.runner.init() File "/home/novikov/work/klever/klever/scheduler/schedulers/native.py", line 102, in init max_processes = max(2, int(max_processes * self._cpu_cores)) TypeError: unsupported operand type(s) for *: 'float' and 'NoneType' Process finished with exit code 1
I suggest to try to solve this issue properly. Perhaps the necessary data can be obtained from consul. Otherwise maybe it has sense to calculate it ourselves always and get rid of the corresponding configuration property since for users it is not so obvious when to use it.
Updated by Ilja Zakharov almost 4 years ago
- Status changed from New to Resolved
Implemented in fix-10596.
Updated by Evgeny Novikov almost 4 years ago
- Status changed from Resolved to Closed
It works, so, I merged the branch to master in b07aee9d1.
Actions