Bug #10478
closedRespect intermixes of declarations and statements
0%
Description
Sometimes developers intermix declarations and statements and sometimes it is not valid to reorder them. For instance, Pavel Andrianov revealed such the case:
mutex_lock(&ldv_lock);
char *ptr = gp;
(it is not valid to change the order of these two lines since a data race can arise).
Updated by Evgeny Novikov over 2 years ago
- Priority changed from High to Urgent
Yet another example shot in another project is declaration that is put somewhere within statements/expressions and that is initialed with a function call. Moving such declarations to the beginning of the function can completely break the logic especially the environment model logic where everything is strictly depend on the context and particular places of corresponding actions.
Updated by Evgeny Novikov over 2 years ago
- Status changed from New to Closed
I fixed this issue in 8ec721468aec. Besides, that commit added a new test case for C Backend. Surprisingly it was not very hard to fix the issue since processing of various cases (variables, labels, type declarations and normal statements) were already supported. It was necessary just to move some handlers to the appropriate places and take into account different cases, e.g. when there is the only variable declaration in a block. Let's see on results of a more exhaustive testing.