Project

General

Profile

Actions

Bug #1029

closed

"make clean" doesn't work for error-trace-visualizer

Added by Andrey Ponomarenko about 13 years ago. Updated almost 13 years ago.

Status:
Closed
Priority:
High
Category:
Infrastructure
Start date:
04/05/2011
Due date:
% Done:

0%

Estimated time:
Detected in build:
git #3fb68331
Platform:
Published in build:
107709b

Description

After the build of ldv-tools I tried to clean the build tree. The command "make clean" failed with the following error log:

make -C rule-instrumentor clean
make[1]: Entering directory `/home/andrey/Desktop/ldv/ldv-tools/rule-instrumentor'
cd aspectator/llvm-2.6 || exit 1; make clean || exit 1
make[2]: Entering directory `/home/andrey/Desktop/ldv/ldv-tools/rule-instrumentor/aspectator/llvm-2.6'
rm -rf ./__isinstalled ./__isinstalled_scripts || exit 1
./ldv-llvm-gcc-install.sh ./__install --uninstall || exit 1
Uninstallation will be done.
Obtain absolute path of install root directory '.'.
Root directory is './__install'.
Obtain absolute path of root directory './__install'.
Clean root directory from previous installation. Remove directories: '/home/andrey/Desktop/ldv/ldv-tools/rule-instrumentor/aspectator/llvm-2.6/__install/llvm-2.6-src', '/home/andrey/Desktop/ldv/ldv-tools/rule-instrumentor/aspectator/llvm-2.6/__install/llvm-2.6-build', '/home/andrey/Desktop/ldv/ldv-tools/rule-instrumentor/aspectator/llvm-2.6/__install/llvm-2.6-bin', '/home/andrey/Desktop/ldv/ldv-tools/rule-instrumentor/aspectator/llvm-2.6/__install/llvm-gcc-2.6-src', '/home/andrey/Desktop/ldv/ldv-tools/rule-instrumentor/aspectator/llvm-2.6/__install/llvm-gcc-2.6-build', '/home/andrey/Desktop/ldv/ldv-tools/rule-instrumentor/aspectator/llvm-2.6/__install/llvm-gcc-2.6-bin', '/home/andrey/Desktop/ldv/ldv-tools/rule-instrumentor/aspectator/llvm-2.6/__install/ldv-llvm-gcc-2.6-test' and '/home/andrey/Desktop/ldv/ldv-tools/rule-instrumentor/aspectator/llvm-2.6/__install/aspectator'.
Please, report bugs to <joker@ispras.ru>.
make[2]: Leaving directory `/home/andrey/Desktop/ldv/ldv-tools/rule-instrumentor/aspectator/llvm-2.6'
make[1]: Leaving directory `/home/andrey/Desktop/ldv/ldv-tools/rule-instrumentor'
make -C error-trace-visualizer clean
make[1]: Entering directory `/home/andrey/Desktop/ldv/ldv-tools/error-trace-visualizer'
make[1]: *** No rule to make target `clean'.  Stop.
make[1]: Leaving directory `/home/andrey/Desktop/ldv/ldv-tools/error-trace-visualizer'
make: *** [error-trace-visualizer-subdir-clean] Error 2

ls error-trace-visualizer

error-trace-visualizer.pl  Makefile

cat error-trace-visualizer/Makefile

INSTALL_DIR = __install

ERROR_TRACE_VISUALIZER_SCRIPT = error-trace-visualizer.pl

# Standard Makefile section.
# Use root installation directory if no prefix was specified.
ifndef prefix
prefix = `readlink -f $(INSTALL_DIR)`
endif
exec_prefix = ${prefix}
bindir = ${exec_prefix}/bin
mandir = ${prefix}/man

# Phony targets.
.PHONY: install all

all:

# Install needed executables to specified path.
install:
  if [ ! -d $(bindir) ]; then mkdir -p $(bindir) || exit 1; fi
  if [ ! -d $(mandir) ]; then mkdir -p $(mandir) || exit 1; fi
  cp $(ERROR_TRACE_VISUALIZER_SCRIPT) $(bindir) || exit 1

The Makefile for error-trace-visualizer doesn't contain the "clean" target, but it is called by the top level Makefile (make -C error-trace-visualizer clean).

Actions #1

Updated by Evgeny Novikov about 13 years ago

  • Category set to Infrastructure
  • Status changed from New to Open
  • Assignee set to Evgeny Novikov
  • Priority changed from Normal to High

A real fail. We don't use make clean but nevertheless our toolset supports it. I guess that the problem isn't just in error-trace-visualizer and all other Makefiles should be investigated.

Actions #2

Updated by Pavel Shved about 13 years ago

BLAST's make clean doesn't fail, but doesn't work properly either: http://forge.ispras.ru/issues/600#note-6

Actions #3

Updated by Evgeny Novikov about 13 years ago

  • Status changed from Open to Resolved
  • Published in build set to 107709b
As I have expected similar problems were encountered in several places:
  • error trace visualizer
  • kernel rules
  • cluster
  • shared/ruby
  • (also I touched stats-server a bit)

I fixed them, although for cluster and shared/ruby cleaning may be implemented correctly (at the moment there are stubs instead).

Actions #4

Updated by Evgeny Novikov almost 13 years ago

  • Status changed from Resolved to Closed

I believe that it works. Reopen if it isn't the case.

Actions

Also available in: Atom PDF