Actions
Task #10139
closedfix coding issues at *BenchTest classes
Start date:
03/02/2020
Due date:
% Done:
0%
Estimated time:
Detected in build:
master
Published in build:
1.1.3-beta-230504
Description
The following issues should be fixed at "*BenchTest" test classes:
- Substitute copy-pasted Javadoc header comments by relevant ones
- ru.ispras.retrascope.engine.cfg.extractor.iface.VhdlCfgExtractorIfaceBenchTest: parameter
getStatistics
is never used atrunTest
method - refactoring is needed - There is a branch order for "if" operator that is used in the project. Following the rule, this form:
if (cond) { ... } else { .. }
is better than:if (!cond) { ... } else { .. }
Take a look at "*BenchTest" classes to fix this rule's violations. - Fix "Local variable 'argPaths' is redundant" warning that appears while opening ru.ispras.retrascope.engine.cfg.transformer.gadd.VerilogCfgGaddBenchTest class in IntelliJ IDEA. This warning also appears at other "*BenchTest" classes too. Other warnings that are produced by IntelliJ IDEA are also worth to be fixed.
- Having expressions like "!x.endsWith(y) && !x.endsWith(z) && !x.endsWith(w) && ..." you should rewrite them with single "!x.matches(..)" expression. Take a look at regular expressions in Java.
Actions